Date: Thu, 30 Apr 2009 05:54:49 +1000 From: peterjeremy@optushome.com.au To: Tim Kientzle <kientzle@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191586 - head/lib/libarchive Message-ID: <20090429195449.GA6715@server.vk2pj.dyndns.org> In-Reply-To: <200904271914.n3RJEhBn024041@svn.freebsd.org> References: <200904271914.n3RJEhBn024041@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 2009-Apr-27 19:14:43 +0000, Tim Kientzle <kientzle@freebsd.org> wrote:
> ino_t varies across platforms; casting (int) here avoids
> various pointless complaints.
...
>+ if ((int)archive_entry_ino(entry) > 0777777) {
But if ino_t is larger than int then truncating it to int will lead
to false negatives here. I don't believe there are any systems where
ino_t is smaller than int so maybe cast the constant to (ino_t) instead.
--
Peter Jeremy
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)
iEYEARECAAYFAkn4sIkACgkQ/opHv/APuIe96ACgoMy68F8/DiBh2JG93270o76K
z/0AnRPx8kJVUvHEphNTpUWiVuXId5LZ
=9u62
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090429195449.GA6715>