Date: Mon, 7 Oct 2019 17:44:39 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513925 - in head/sysutils: . rshim-user-space Message-ID: <ab60b562-71c1-3639-99bc-0001e4972d22@selasky.org> In-Reply-To: <20191007081234.p2kucsd6c3erfvet@atuin.in.mat.cc> References: <201910070806.x9786o7L034374@repo.freebsd.org> <20191007081234.p2kucsd6c3erfvet@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-10-07 10:12, Mathieu Arnold wrote: > On Mon, Oct 07, 2019 at 08:06:50AM +0000, Hans Petter Selasky wrote: >> +PORTNAME= rshim-user-space >> +GH_PROJECT= rshim-user-space > > Please remove GH_PROJECT, its default value is PORTNAME. > >> +PORTVERSION= 1.0 >> +GH_TAGNAME= v1.0-alpha.1 > > So, PORTVERSION says 1.0 and the tag says it is an alpha release. > PORTVERSION is probably wrong and this should have been done in its > stead (and removing GH_TAGNAME in the process): > > DISTVERSIONPREFIX= v > DISTVERSION= 1.0-alpha.1 > >> +OPTIONS_DEFAULT= > > Please remove this empty variable. > Will do. Thanks for the feedback! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ab60b562-71c1-3639-99bc-0001e4972d22>