Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 25 Nov 2020 17:12:21 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r368024 - head/sys/ufs/ffs
Message-ID:  <202011251712.0APHCL8m002762@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: kib
Date: Wed Nov 25 17:12:21 2020
New Revision: 368024
URL: https://svnweb.freebsd.org/changeset/base/368024

Log:
  ffs_softdep.c: get_parent_vp(): Fix bp lock leak when inum inode was already freed.
  
  Reported by:	markj, pho
  Tested by:	pho
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.c	Wed Nov 25 17:04:26 2020	(r368023)
+++ head/sys/ufs/ffs/ffs_softdep.c	Wed Nov 25 17:12:21 2020	(r368024)
@@ -1409,6 +1409,29 @@ SYSCTL_INT(_debug_softdep, OID_AUTO, print_threads, CT
 /* List of all filesystems mounted with soft updates */
 static TAILQ_HEAD(, mount_softdeps) softdepmounts;
 
+static void
+get_parent_vp_unlock_bp(struct mount *mp, struct buf *bp,
+    struct diraddhd *diraddhdp, struct diraddhd *unfinishedp)
+{
+	struct diradd *dap;
+
+	/*
+	 * Requeue unfinished dependencies before
+	 * unlocking buffer, which could make
+	 * diraddhdp invalid.
+	 */
+	ACQUIRE_LOCK(VFSTOUFS(mp));
+	while ((dap = LIST_FIRST(unfinishedp)) != NULL) {
+		LIST_REMOVE(dap, da_pdlist);
+		LIST_INSERT_HEAD(diraddhdp, dap, da_pdlist);
+	}
+	FREE_LOCK(VFSTOUFS(mp));
+
+	bp->b_vflags &= ~BV_SCANNED;
+	BUF_NOREC(bp);
+	BUF_UNLOCK(bp);
+}
+
 /*
  * This function fetches inode inum on mount point mp.  We already
  * hold a locked vnode vp, and might have a locked buffer bp belonging
@@ -1439,7 +1462,6 @@ get_parent_vp(struct vnode *vp, struct mount *mp, ino_
     struct vnode **rvp)
 {
 	struct vnode *pvp;
-	struct diradd *dap;
 	int error;
 	bool bplocked;
 
@@ -1455,31 +1477,18 @@ get_parent_vp(struct vnode *vp, struct mount *mp, ino_
 			 * restart the syscall.
 			 */
 			if (VTOI(pvp)->i_mode == 0 || !bplocked) {
+				if (bp != NULL && bplocked)
+					get_parent_vp_unlock_bp(mp, bp,
+					    diraddhdp, unfinishedp);
 				if (VTOI(pvp)->i_mode == 0)
 					vgone(pvp);
-				vput(pvp);
 				error = ERELOOKUP;
-				goto out;
+				goto out2;
 			}
-
-			error = 0;
 			goto out1;
 		}
 		if (bp != NULL && bplocked) {
-			/*
-			 * Requeue unfinished dependencies before
-			 * unlocking buffer, which could make
-			 * diraddhdp invalid.
-			 */
-			ACQUIRE_LOCK(VFSTOUFS(mp));
-			while ((dap = LIST_FIRST(unfinishedp)) != NULL) {
-				LIST_REMOVE(dap, da_pdlist);
-				LIST_INSERT_HEAD(diraddhdp, dap, da_pdlist);
-			}
-			FREE_LOCK(VFSTOUFS(mp));
-			bp->b_vflags &= ~BV_SCANNED;
-			BUF_NOREC(bp);
-			BUF_UNLOCK(bp);
+			get_parent_vp_unlock_bp(mp, bp, diraddhdp, unfinishedp);
 			bplocked = false;
 		}
 
@@ -1528,13 +1537,13 @@ get_parent_vp(struct vnode *vp, struct mount *mp, ino_
 		MPASS(!bplocked);
 		error = ERELOOKUP;
 	}
+out2:
 	if (error != 0 && pvp != NULL) {
 		vput(pvp);
 		pvp = NULL;
 	}
 out1:
 	*rvp = pvp;
-out:
 	ASSERT_VOP_ELOCKED(vp, "child vnode must be locked on return");
 	return (error);
 }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011251712.0APHCL8m002762>