Date: Wed, 25 May 2011 10:38:22 -0700 From: Xin LI <delphij@delphij.net> To: Pan Tsu <inyaoo@gmail.com> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI <delphij@FreeBSD.ORG> Subject: Re: svn commit: r222211 - head/usr.bin/gzip Message-ID: <4DDD3E8E.7090806@delphij.net> In-Reply-To: <86vcwy67bm.fsf@gmail.com> References: <201105230940.p4N9eLQ1014007__26701.9700528637$1306143644$gmane$org@svn.freebsd.org> <86vcwy67bm.fsf@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Pan, On 05/25/11 10:03, Pan Tsu wrote: >> Match symbolic link handling behavior with GNU gzip, bzip2 and xz: > > After this change zcat(1) behaves unlike GNU zcat, bzcat and xzcat. > > $ zcat TIFFfree.3tiff.gz > zcat: TIFFfree.3tiff.gz is not a regular file > Exit 1 Will the attached patch help? [...] > At least our man(1) relies on foocat, e.g. [...] > and uses `-f' flag only when compression is not known/not compressed I think this is a gzip(1) bug and thus it's not man(1) to be fixed. However, that might indicate a different bug (thankfully it revealed the gzip(1) one) in the TIFF port :) Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJN3T6NAAoJEATO+BI/yjfB/4YIALvCH1J1GvbHFXn8aN4msBnY 28RnaioHsOpABVwJJ4H6HR6hh3XEC/rU6LeQaCocZ3K+THkKc4+OvvLJwi/QEiLz 0i4zW/K0ZM3BrwjmCuoTHSNPCTkAAcEPiGQt2XjvgPRzAXOeQSI16ABbl98i6OeK nT2ntP9izC4A0VR+YBPBYAjCi7u1Yers46fhjTEDi0ISpuKiONPeU32ZyIttee/U j0uRc4PBxAsrGZTkhMn2qB3pVRIfQje+eUxB/yHQs3JwW9CIZ/VWprIlfn1S5Gr+ JPsNeBGRYWTUS2MJyn9uEmiMZvOzGO0rzATKgzyoP6yBrUCmSQhAO6DpkMTibj8= =kLw1 -----END PGP SIGNATURE----- [-- Attachment #2 --] Index: usr.bin/gzip/gzip.c =================================================================== --- usr.bin/gzip/gzip.c (revision 222265) +++ usr.bin/gzip/gzip.c (working copy) @@ -1782,7 +1782,8 @@ } retry: - if (stat(path, &sb) != 0 || (fflag == 0 && lstat(path, &sb) != 0)) { + if (stat(path, &sb) != 0 || (fflag == 0 && cflag == 0 && + lstat(path, &sb) != 0)) { /* lets try <path>.gz if we're decompressing */ if (dflag && s == NULL && errno == ENOENT) { len = strlen(path);help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DDD3E8E.7090806>