Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Dec 2018 02:37:55 +0800
From:      Marcelo Araujo <araujobsdport@gmail.com>
To:        Alexander Motin <mav@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r342349 - head/usr.sbin/ctladm
Message-ID:  <CAOfEmZho%2Bzs5Cjk1_Cc5sQa7ndCfbjL0Q5zJo2yJv2_Q=hJKXw@mail.gmail.com>
In-Reply-To: <201812211722.wBLHMF3V011619@repo.freebsd.org>
References:  <201812211722.wBLHMF3V011619@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Em s=C3=A1b, 22 de dez de 2018 =C3=A0s 01:22, Alexander Motin <mav@freebsd.=
org>
escreveu:

> Author: mav
> Date: Fri Dec 21 17:22:15 2018
> New Revision: 342349
> URL: https://svnweb.freebsd.org/changeset/base/342349
>
> Log:
>   Fix passing wrong variables to nvlist_destroy() after r333446.
>
>   Reported by:  Alexander Fedorov (IT-Grad.ru)
>   MFC after:    5 days
>

Thanks to fix that!

Out of curiosity, that was reported by email, bugzilla or any other place?

Best,


>
> Modified:
>   head/usr.sbin/ctladm/ctladm.c
>
> Modified: head/usr.sbin/ctladm/ctladm.c
>
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/usr.sbin/ctladm/ctladm.c       Fri Dec 21 17:18:33 2018
> (r342348)
> +++ head/usr.sbin/ctladm/ctladm.c       Fri Dec 21 17:22:15 2018
> (r342349)
> @@ -667,7 +667,7 @@ cctl_port(int fd, int argc, char **argv, char *combin=
e
>         }
>
>  bailout:
> -       nvlist_destroy(req.args_nvl);
> +       nvlist_destroy(option_list);
>         free(driver);
>         return (retval);
>
> @@ -2542,7 +2542,7 @@ cctl_create_lun(int fd, int argc, char **argv, char
> *c
>         fprintf(stdout, "Device ID:     %s\n",
> req.reqdata.create.device_id);
>
>  bailout:
> -       nvlist_destroy(req.args_nvl);
> +       nvlist_destroy(option_list);
>         return (retval);
>  }
>
> @@ -2644,7 +2644,7 @@ cctl_rm_lun(int fd, int argc, char **argv, char
> *combi
>         printf("LUN %d removed successfully\n", lun_id);
>
>  bailout:
> -       nvlist_destroy(req.args_nvl);
> +       nvlist_destroy(option_list);
>         return (retval);
>  }
>
> @@ -2764,7 +2764,7 @@ cctl_modify_lun(int fd, int argc, char **argv, char
> *c
>         printf("LUN %d modified successfully\n", lun_id);
>
>  bailout:
> -       nvlist_destroy(req.args_nvl);
> +       nvlist_destroy(option_list);
>         return (retval);
>  }
>
>
>

--=20

--=20
Marcelo Araujo            (__)araujo@FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>;   \/  \ ^
Power To Server.         .\. /_)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZho%2Bzs5Cjk1_Cc5sQa7ndCfbjL0Q5zJo2yJv2_Q=hJKXw>