Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Oct 2013 02:55:31 +0000 (UTC)
From:      Kevin Lo <kevlo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r256574 - head/usr.sbin/ppp
Message-ID:  <201310160255.r9G2tV22097799@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevlo
Date: Wed Oct 16 02:55:31 2013
New Revision: 256574
URL: http://svnweb.freebsd.org/changeset/base/256574

Log:
  Fix logic error.  MPPE only accepts protocol numbers 0x21 through 0xFA.
  
  PR:	bin/175974

Modified:
  head/usr.sbin/ppp/mppe.c

Modified: head/usr.sbin/ppp/mppe.c
==============================================================================
--- head/usr.sbin/ppp/mppe.c	Wed Oct 16 02:46:00 2013	(r256573)
+++ head/usr.sbin/ppp/mppe.c	Wed Oct 16 02:55:31 2013	(r256574)
@@ -168,7 +168,7 @@ MPPEOutput(void *v, struct ccp *ccp, str
   dictinit = 0;
 
   log_Printf(LogDEBUG, "MPPE: Output: Proto %02x (%d bytes)\n", *proto, ilen);
-  if (*proto < 0x21 && *proto > 0xFA) {
+  if (*proto < 0x21 || *proto > 0xFA) {
     log_Printf(LogDEBUG, "MPPE: Output: Not encrypting\n");
     ccp->compout += ilen;
     ccp->uncompout += ilen;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310160255.r9G2tV22097799>