Date: Sun, 30 Apr 2000 12:06:21 -0700 From: "Andrey A. Chernov" <ache@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <20000430120621.A22259@freebsd.org> In-Reply-To: <20000430112344.A13987@freebsd.org>; from ache@freebsd.org on Sun, Apr 30, 2000 at 11:23:44AM -0700 References: <200004301600.JAA18945@freefall.freebsd.org> <Pine.BSF.4.21.0005010354410.2953-100000@alphplex.bde.org> <20000430112344.A13987@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 30, 2000 at 11:23:44AM -0700, Andrey A. Chernov wrote: > On Mon, May 01, 2000 at 04:11:56AM +1000, Bruce Evans wrote: > > This is all very broken. It used to be possible to set the drainwait timeout > > using comcontrol and have the setting live across closes. /etc/rc.serial > > has examples of setting it. Now, the setting gets clobbered in ttyopen() > > not only for first opens, but for open of the termios line discipline, i.e., > > for every open(2) and for every reentry to the termios line discipline > > (TIOCSETD to TTYDISC). This bug was introduced in the previous commit. > > The sysctl just allows changing the default value that is used to clobber > > the setting. > > BTW, you say nothing when I send initial patch for review. > Probably ttyopen not the best place for setting t_timeout to its default value. > What place you suggest as better one? Probably we can initialize t_timeout not to 0 but to -1 in upper layer, then use in ttyopen something like this: if (tp->t_timeout < 0) tp->t_timeout = drainwait * hz; -- Andrey A. Chernov <ache@nagual.pp.ru> http://nagual.pp.ru/~ache/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000430120621.A22259>