Date: Sat, 29 Jun 1996 20:02:28 +0200 From: Wolfram Schneider <wosch@softs11.ZIB-Berlin.DE> To: Bruce Evans <bde@zeta.org.au> Cc: freebsd-current@freebsd.org, jhay@mikom.csir.co.za, jkh@freebsd.org, wosch@freebsd.org Subject: Re: make clean in src/lkm problems Message-ID: <199606291802.UAA01063@campa.panke.de> In-Reply-To: <199606290927.TAA32420@godzilla.zeta.org.au> References: <199606290927.TAA32420@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans writes: >This is just a bug in the nesting of the target in *.mk. bsd.kmod.mk >doesn't have its own clean target. It gets a bad one (depending on >_SUBDIR but not on cleanfiles) by including bsd.dep.mk before including >bsd.obj.mk. This breaks cleaning in all lkm directories, independent of >the existence and location of the obj directories. Jordan changed the order of the include files in bsd.kmod.mk. JOOOOOOOOOOOOOOOOOOOOOOORDAAAAAAAAAAAAAAAN! Why did you do that? The order is still important. And the order will be important if we move bsd.own.mk from sys.mk to bsd.*.mk files. Please put bsd.obj.mk before bsd.dep.mk in bsd.kmod.mk. >All the other top level bsd.*.mk files avoid this problem by having their >own `clean' target. All except bsd.sgml.mk (remember the problem with undeleted *.html files). bsd.sgml.mk should not include bsd.dep.mk because bsd.dep.mk is for `c' sources. >Complete fix: either remove `clean' targets from included files, or >define them in only one included file, or use use `clean::' instead of >`clean:' to allow the rules to accumulate. The current method of >defining `clean' targets in included files if the target doesn't already >exist just breaks things if the files are included in an unfortunate >order. My intention was a single 'clean:' target in bsd.obj.mk. Except if the top makefile (./obj/Makefile, ./Makefile) does have their own clean target. PS: now I have ~200 'obj' trouble mails in my mailbox. Was it that worth? Wolfram <wosch@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199606291802.UAA01063>