Date: Fri, 6 Jun 2008 13:15:52 +0100 From: Rui Paulo <rpaulo@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: kib@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org>, current@FreeBSD.org Subject: Re: cpuctl(formely devcpu) patch test request Message-ID: <20080606121552.GA7768@epsilon.local> In-Reply-To: <20080606020927.8d6675e1.stas@FreeBSD.org> References: <20080605231705.db589d89.stas@FreeBSD.org> <20080605204823.GA7361@epsilon.local> <20080606020927.8d6675e1.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 06, 2008 at 02:09:27AM +0400, Stanislav Sedov wrote: > On Thu, 5 Jun 2008 21:55:39 +0100 > Rui Paulo <rpaulo@FreeBSD.org> mentioned: > > > A couple comments: > > 1) Do you plan to MFC this ? For what older versions of FreeBSD will devcpu be > > shipped? > > In fact, I plan to MFC that to all supported FreeBSD versions (6, 7), > as changes are minimal. Until that those versions will be supported > by sysutils/devcpu port. Ok. > > > > 2) in cpuctl_modevent(): perhaps it's better to return ENOMEM instead of > > ENOSYS if malloc() fails and ENXIO instead of ENOSYS if MSR functionality is > > not present > > I fully agree on ENOMEM (thanks for noticing that), while I think that > returning ENOSYS for MSR-less systems is more correct, as it states that > required functionality isn't implemented for this hardware. Agreed. > > 3) I don't mean to impose, but this code needs some small style cleanup, > > namely: characters above the 80 column, second level indents are four > > spaces" > > Good catch! Fixed. Good, thanks. -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080606121552.GA7768>