Date: Mon, 15 Jul 2002 13:23:23 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: keramida@FreeBSD.org Cc: bde@zeta.org.au, des@ofug.org, freebsd-audit@FreeBSD.org Subject: Re: bin/ln & WARNS=5 Message-ID: <20020715.132323.19489929.imp@bsdimp.com> In-Reply-To: <20020715182514.GC55859@hades.hell.gr> References: <20020715111436.GD50130@hades.hell.gr> <20020715.090420.83279095.imp@bsdimp.com> <20020715182514.GC55859@hades.hell.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
This looks good to me. I'd quibble over sizeof path vs sizeof(path), but that's not enough for you to necessarily change it :-). We've also used snprintf in preference to sprintf because the former is a failsafe interface, while the latter could do weird things if our checks are incoorect for some reason. The + 2 looks good to me, and I agree with it. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020715.132323.19489929.imp>