Date: Fri, 24 Jul 2009 13:54:34 -0400 From: John Baldwin <jhb@freebsd.org> To: Jack F Vogel <jfv@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195851 - in head/sys/dev: e1000 ixgbe Message-ID: <200907241354.34889.jhb@freebsd.org> In-Reply-To: <200907241657.n6OGvoQX015880@svn.freebsd.org> References: <200907241657.n6OGvoQX015880@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 24 July 2009 12:57:50 pm Jack F Vogel wrote: > Author: jfv > Date: Fri Jul 24 16:57:49 2009 > New Revision: 195851 > URL: http://svn.freebsd.org/changeset/base/195851 > > Log: > This delta fixes two bugs: > - When a vlan event occurs a check was not made that > the event was actually for the interface, thus resulting > in a panic. All three drivers have this vulnerability. Add > a check for this condition. These are still not correct. You need to check the softc as in the latest patch I sent. Otherwise if you have multiple em(4) or igb(4) interfaces in a machine you will register vlan's on all the em/igb interfaces multiple times. E.g., if you added a em0.500 and em1.502, you would actually end up with both em0 and em1 doing hardware tagging for both vlans 500 and 502. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907241354.34889.jhb>