Date: Mon, 07 Aug 2006 10:14:17 -0700 From: Julian Elischer <julian@elischer.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Stefan Farfeleder <stefanf@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw2.c Message-ID: <44D774E9.4010309@elischer.org> In-Reply-To: <20060807092251.GS96644@FreeBSD.org> References: <200608051358.k75DwpYr070713@repoman.freebsd.org> <20060807092251.GS96644@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Gleb Smirnoff wrote: >On Sat, Aug 05, 2006 at 01:58:50PM +0000, Stefan Farfeleder wrote: >S> stefanf 2006-08-05 13:58:50 UTC >S> >S> FreeBSD src repository >S> >S> Modified files: >S> sbin/ipfw ipfw2.c >S> Log: >S> Use the SLIST_NEXT macro instead of sle_next. > >Uhhrm. This code is a hack really, and using bad style emphasizes >that. It says: BEWARE! We use queue.h internals for our own dirty >needs. So I left "sle_next" here intentionally. > >The hack was made here to keep ABI compatibility, and make the later >changes mergeable to RELENG_6. > >Let it be SLIST_NEXT() now. Anyway there is a plan of major rewrite >of API and ipfw(8) itself. > > > great.. I have been in ipfw(2) the last week and have some sugestions for increasing its efficiency.. especially the code that times out dynamic rules.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44D774E9.4010309>