Date: Fri, 14 Mar 2014 08:22:16 -0700 From: Rui Paulo <rpaulo@FreeBSD.org> To: Hans Petter Selasky <hps@bitfrost.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r262972 - head/sys/dev/usb/input Message-ID: <C486FB67-41F4-4E13-8B91-A3AD1203F139@FreeBSD.org> In-Reply-To: <5322CCC5.7020608@bitfrost.no> References: <201403100852.s2A8qUdC045704@svn.freebsd.org> <D62898EB-F179-416B-A481-68604873477C@FreeBSD.org> <5322CCC5.7020608@bitfrost.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 Mar 2014, at 02:32, Hans Petter Selasky <hps@bitfrost.no> wrote: > On 03/14/14 03:15, Rui Paulo wrote: >> On 10 Mar 2014, at 01:52, Hans Petter Selasky <hselasky@freebsd.org> = wrote: >>=20 >>> Author: hselasky >>> Date: Mon Mar 10 08:52:30 2014 >>> New Revision: 262972 >>> URL: http://svnweb.freebsd.org/changeset/base/262972 >>>=20 >>> Log: >>> Ignore USB keyboard driver calls from critical sections. >>>=20 >>> Reported by: Oliver Pinter <oliver.pntr@gmail.com> >>> MFC after: 1 week >>>=20 >>> Modified: >>> head/sys/dev/usb/input/ukbd.c >>>=20 >>> Modified: head/sys/dev/usb/input/ukbd.c >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/dev/usb/input/ukbd.c Mon Mar 10 06:41:48 2014 = (r262971) >>> +++ head/sys/dev/usb/input/ukbd.c Mon Mar 10 08:52:30 2014 = (r262972) >>> @@ -1909,6 +1909,12 @@ ukbd_ioctl(keyboard_t *kbd, u_long cmd, >>> int result; >>>=20 >>> /* >>> + * XXX Check of someone is calling us from a critical section: >>> + */ >>> + if (curthread->td_critnest !=3D 0) >>> + return (EDEADLK); >>=20 >> Shouldn't this panic? >>=20 >> -- >> Rui Paulo >>=20 >=20 > Hi, >=20 > This happens on shutdown, in some special case. Not sure if panic at = shutdown is appropriate? I thought this was a programming error. Do we know the special cases = and why it happens? -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C486FB67-41F4-4E13-8B91-A3AD1203F139>