Date: Wed, 6 Apr 2011 10:22:32 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: =?ISO-8859-2?Q?Edward_Tomasz_Napiera=B3a?= <trasz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r220387 - head/sys/vm Message-ID: <BANLkTikAw6e8Nux1sZL9QFpTBPMgw2-p8A@mail.gmail.com> In-Reply-To: <28CBF3B2-105E-4B0F-A1B1-4FA772BAB06A@freebsd.org> References: <201104061627.p36GR4Vx097282@svn.freebsd.org> <BANLkTin=xKmJf6HJ%2Beb9CUcnerdv=fNp1w@mail.gmail.com> <28CBF3B2-105E-4B0F-A1B1-4FA772BAB06A@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/4/6 Edward Tomasz Napierała <trasz@freebsd.org>: > Wiadomość napisana przez Garrett Cooper w dniu 2011-04-06, o godz. 18:57: >> On Wed, Apr 6, 2011 at 9:27 AM, Edward Tomasz Napierala >> <trasz@freebsd.org> wrote: >>> Author: trasz >>> Date: Wed Apr 6 16:27:04 2011 >>> New Revision: 220387 >>> URL: http://svn.freebsd.org/changeset/base/220387 >>> >>> Log: >>> In vm_daemon(), do not skip processes stopped with SIGSTOP. >> >> Did you run this by anyone else before you committed the change? > > The whole racct patchset was reviewed by kib@, and I seem to remember > that he said this might cause problems. However, I didn't encounter > any problems with this, neither did any person testing the patchset. > > So, what's wrong with this? My concern was just that "Reviewed by" was missing and that this might introduce some unexpected functional issues (then again it's now going to kill stopped processes, right?). -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTikAw6e8Nux1sZL9QFpTBPMgw2-p8A>