Date: Wed, 7 Mar 2018 17:03:13 +0000 From: "fabian.freyer_physik.tu-berlin.de (Fabian Freyer)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D14473: userboot: add callbacks to set unrestricted guest mode Message-ID: <2843ee914c79e89f13a257933489caf7@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-z4kdgdlru2lrsvfkw4bo-req@FreeBSD.org> References: <differential-rev-PHID-DREV-z4kdgdlru2lrsvfkw4bo-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
fabian.freyer_physik.tu-berlin.de added a comment. In D14473#306827 <https://reviews.freebsd.org/D14473#306827>, @grehan wrote: > So a comment on this: in general, api's are not added to FreeBSD that don't have base-system clients that use them, or for a good reason. I think this falls into the latter but I'd like to cut it down a bit. > > - can the get_unrestricted_guest() routine be removed ? There is an error return on the set, which seems like it can be used to determine if unrestricted mode is not available (e.g. that's how bhyve uses the ioctl). Yes, it can. > - is there a need for vcpu_reset() ? The BSP should be initialized to power-on state.. That could be a bug in bhyve and better to have it fixed there. Not necessarily, as everything in vcpu_reset() could also be accomplished with the other callbacks. I don't think bhyverun should call vcpu_reset(), as bhyveload sets up registers before. I guess this should happen before `loader_main` is called? REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: fabian.freyer_physik.tu-berlin.de, imp, rgrimes, #bhyve, grehan Cc: grehan, imp, freebsd-virtualization-list, #contributor_reviews_base
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2843ee914c79e89f13a257933489caf7>