Date: Wed, 05 Jun 2002 16:47:39 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Jake Burkholder <jake@locore.ca> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/common ufsread.c src/sys/boot/sparc64/boot1 Makefile boot1.c Message-ID: <51033.1023288459@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 05 Jun 2002 11:03:03 EDT." <20020605110302.D54588@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020605110302.D54588@locore.ca>, Jake Burkholder writes: >Apparently, On Wed, Jun 05, 2002 at 05:00:53AM -0700, > Poul-Henning Kamp said words to the effect of; > >> phk 2002/06/05 05:00:53 PDT >> >> Modified files: >> sys/boot/common ufsread.c >> sys/boot/sparc64/boot1 Makefile boot1.c >> Log: >> Make sparc64 share ufsread.c with i386. > >Wouldn't it be better to link with this file rather than #including it? In theory yes, but in practice I think not. The various platforms have made different choices for how to deal with stuff like memcpy, strcmp and so on, so I think trying to keep under the size-limits while putting this in a separate object file will be non-trivial. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51033.1023288459>