Date: Mon, 28 Oct 2013 06:33:43 -0200 From: Renato Botelho <garga@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r331439 - head/security/checkpassword Message-ID: <526E2167.4030309@FreeBSD.org> In-Reply-To: <20131028045406.GA30390@FreeBSD.org> References: <201310232232.r9NMWeoP077908@svn.freebsd.org> <20131028045406.GA30390@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QDRRxRcbs02m1rRuq8uDBMhfQAj44lv47 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 28-10-2013 02:54, Alexey Dokuchaev wrote: > On Wed, Oct 23, 2013 at 10:32:40PM +0000, Renato Botelho wrote: >> New Revision: 331439 >> URL: http://svnweb.freebsd.org/changeset/ports/331439 >> >> [...]=20 >> -NO_STAGE=3D yes >> .include <bsd.port.pre.mk> >> [...]=20 >> .if ${PORT_OPTIONS:MDOCS} >> - ${MKDIR} ${DOCSDIR} >> + ${MKDIR} ${STAGEDIR}${DOCSDIR} >> .for f in ${PORTDOCS} >> - ${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR} >> + ${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR} >=20 > Since this port is not actually doing something nasty to build those do= cs, > you could have simply remove .if ${PORT_OPTIONS:MDOCS} check. This wou= ld > make the Makefile cleaner, and you and even drop .include <bsd.port.pre= =2Emk> > (but don't forget to adjust <bsd.port.post.mk> -> <bsd.port.pre.mk>). What you are proposing is to always intall docs? Even if user has DOCS option unset? --=20 Renato Botelho <garga @ FreeBSD.org> <garga.bsd @ gmail.com> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc --QDRRxRcbs02m1rRuq8uDBMhfQAj44lv47 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJSbiFoAAoJEPHw56GfYleQnKgP/24sy0zI2Bea5xtzh1atWWgg hkQoqLH19WVmuf4O8fDyaoT3NvhFVqJ9Df1P4mu88YVX0YWnPno98Gg3H4Ks+tGg as5W1kFKoIMxNVjtXTXrDkQl871BzGc1Tvz8sFomC8ky3iWHuiEGNQpNonOhsdWb R7KY0a8+dHzqAdvHH4vBUpi4Mz8xJXdlg32+yJuG4xgcbVnDFDc2tG4djPp2APEB OIkGUJAr874LM6Vfa/sXAYzh2LuRBkHGoRlUuKEbFXN+u6Qp5qAm1qcbmn8cPnkw UTFcRndDrX3lsHREIoTYjYmLPXGtlX+wu90kr4iZp7QFcmQ/tti+L/Uy4PI0H5ZX pDz7FGWwd9VTQv4kPsLa7IkcYMC1JqPlDi6zzCQ1nNJd5pXjwxyvF9TKk4u6/7la 22+KUesjxnFX3WuEcgRMWf7fui1HDUY95AVTbESGsopwoiyDAO8wI9gnG/2aYUyk nNYiwicPl+l5+sKFD2ldV3WIJtQhCwQgCcALYi5ZoS1cfu/MHFArqke8Qbg2J99f JZVcVtuja8ke6AJj22kOyQUNEjc4UuyNzCqpopTjewXudQOfm0UTLU+PNpYNAGVh 53nBFKtI1bQNyCLWR0lRmIrs5CTLhB0Lf3RCqneugNke2XKTldIylPxjpXvb8eJk TNC6WjTewdjfCIG1TXRn =Kq7c -----END PGP SIGNATURE----- --QDRRxRcbs02m1rRuq8uDBMhfQAj44lv47--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?526E2167.4030309>