Date: Mon, 18 Jan 2016 16:48:28 +0100 From: Gary Jennejohn <gljennjohn@gmail.com> To: "Ronald Klop" <ronald-lists@klop.ws> Cc: freebsd-fs@freebsd.org Subject: Re: [Bug 206328] Crash on shutdown with swap on NFS file (with patch) Message-ID: <20160118164828.2aedaac8@ernst.home> In-Reply-To: <op.ybfobwktkndu52@ronaldradial.radialsg.local> References: <bug-206328-3630@https.bugs.freebsd.org/bugzilla/> <bug-206328-3630-prHGdYMqZV@https.bugs.freebsd.org/bugzilla/> <op.ybfobwktkndu52@ronaldradial.radialsg.local>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 18 Jan 2016 13:15:22 +0100 "Ronald Klop" <ronald-lists@klop.ws> wrote: > On Mon, 18 Jan 2016 10:48:10 +0100, <bugzilla-noreply@freebsd.org> wrote: > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206328 > > > > --- Comment #3 from Tom Vijlbrief <tvijlbrief@gmail.com> --- > > bufshutdown() ends with: > > > > > > if (panicstr == NULL) > > vfs_unmountall(); > > } > > swapoff_all(); > > > > Why not just reverse the order? > > > > So swapoff_all() before the vfs_unmountall(), so that the NFS filesystem > > is > > still available. > > > > Perhaps even at the start of bufshutdown(). > > > > Still wondering what the reason of a swapoff_all() call just before the > > actual > > reboot is. > > > > Maybe... leaving swap on a mirrored disk will give a rebuild of the mirror > on boot if swap is not swapped off. > Right, eventually swapgeom_close() gets called to clean things up. Still, it seems rather strange that all the swapped out pages are paged back in when the utlimate goal is to close the swap devices cleanly. Of course, there is some logic in the code to handle the case where some process(es) may be actively swapping while the kernel is shutting things down. -- Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160118164828.2aedaac8>