Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 May 2024 17:05:14 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        Lexi Winter <lexi@le-fay.org>
Cc:        Mariusz Zaborski <oshogbo@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 408957613bc0 - main - Regen
Message-ID:  <Zk4lyti6kSjAux1t@spindle.one-eyed-alien.net>
In-Reply-To: <Zk2lBymRapenk_V8@ilythia.eden.le-fay.org>
References:  <202405212004.44LK4cBG042804@gitrepo.freebsd.org> <Zk2lBymRapenk_V8@ilythia.eden.le-fay.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 22, 2024 at 08:55:51AM +0100, Lexi Winter wrote:
> Mariusz Zaborski:
> > The branch main has been updated by oshogbo:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c4444812c3ae276ace03697ebd
> > 
> > commit 408957613bc065c4444812c3ae276ace03697ebd
> > Author:     Mariusz Zaborski <oshogbo@FreeBSD.org>
> > AuthorDate: 2024-05-21 20:02:50 +0000
> > Commit:     Mariusz Zaborski <oshogbo@FreeBSD.org>
> > CommitDate: 2024-05-21 20:03:20 +0000
> > 
> >     Regen
> > ---
> >  sys/compat/freebsd32/freebsd32_sysent.c | 2 +-
> >  sys/kern/init_sysent.c                  | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> i'm sorry if this is considered accepted practice in FreeBSD (i'm not a
> committer) but could i please request more useful commit messages than
> "Regen" for things like this?

This is more or less standard practice for generated files.  These
commits are of basically no interest.  Historically they had to exist
because the source file $FreeBSD$ entries were embedded in the generated
files and thus had to be final.  That isn't true any more so I often just
include them in the origional commit unless I'm doing a lot of minor
changes to the source files.

-- Brooks



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Zk4lyti6kSjAux1t>