Date: Wed, 26 Nov 2008 21:14:33 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Max Laier <max@love2party.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185344 - in head/sys: netinet netinet6 Message-ID: <20081126211242.T61259@maildrop.int.zabbadoz.net> In-Reply-To: <200811262208.48429.max@love2party.net> References: <200811262052.mAQKqRN5065921@svn.freebsd.org> <200811262208.48429.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 26 Nov 2008, Max Laier wrote: > On Wednesday 26 November 2008 21:52:27 Bjoern A. Zeeb wrote: >> Author: bz >> Date: Wed Nov 26 20:52:26 2008 >> New Revision: 185344 >> URL: http://svn.freebsd.org/changeset/base/185344 >> >> Log: >> Remove in6_pcbdetach() as it is exactly the same function >> as in_pcbdetach() and we don't need the code twice. >> >> Reviewed by: rwatson >> MFC after: 6 weeks (*) >> (*) possibly need to leave a stub wrapper in 7 to keep the symbol. > > Won't this affect our ability to build INET6, but non INET kernels? Not that > we currently could, but if we ever wanted to? Nope. though maybe for the moment. The point is if you go by that argument you would have to duplicate half of the network stack. The trick will be to hide the IPv4 only parts with #ifdef INET in the next step and compile the common code optional inet || inet6 but I need to check our build foo and it'll be a long way there anyway... -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081126211242.T61259>