Date: Wed, 24 Dec 2014 21:53:57 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: Marcel Moolenaar <marcel@freebsd.org>, Phil Shafer <phil@juniper.net>, John-Mark Gurney <jmg@funkthat.com>, arch@freebsd.org, Poul-Henning Kamp <phk@phk.freebsd.dk>, freebsd-arch <freebsd-arch@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com> Subject: Libxo bugs and fixes. Message-ID: <549BA675.9070107@freebsd.org> In-Reply-To: <20140816045254.5F47E580A2@chaos.jnpr.net> References: <201408141640.s7EGe422096656@idle.juniper.net> <53ED57F2.5020808@mu.org> <20140815053604.9E40B580A2@chaos.jnpr.net> <53EDB0EF.6090902@mu.org> <20140815173830.93832580A2@chaos.jnpr.net> <53EEA74B.9070107@mu.org> <20140816045254.5F47E580A2@chaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/15/14 9:52 PM, Simon J. Gerraty wrote: > On Fri, 15 Aug 2014 17:35:23 -0700, Alfred Perlstein writes: >> should get towards converting more utils to using it. However if we are >> going to perpetually add frameworky things, but not convert over >> userland tools to the actual framework, then that is a potential problem >> worth calling out. > Indeed. Again that's why I prefer to see this (the library at least) > done by someone who's been doing this sort of thing successfuly for > ages. OK, So I've been hacking on this over the last day or so and have the following deltas up for review: 1) We need libxo to support explicit fflush: https://reviews.freebsd.org/D1379 2) We need libxo to support time series data. I don't have a patch for that, but I would like to ask for ideas on this. This would be extremely helpful for instance "netstat 1". would like to get a very accurate timestamp with each row. Suggestions on how to do this correctly AND *consistently* via libxo would make sense. 3) I have netstat mostly converted over, however not all the json is valid, I will be doing another pass ASAP on this. https://reviews.freebsd.org/D1380 4) Can I as politely as I know how, ask that Juniper keep the patches against the userland utils up to date either in a project branch in SVN, or simply in a fork of the github repo? This would make life so much easer to deal with. As an example you can look at my github repo where I have the netstat code forward ported on a branch here: https://github.com/splbio/freebsd/tree/ap_libxo_netstat and here: https://github.com/splbio/freebsd/compare/ap_libxo_netstat?expand=1 -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?549BA675.9070107>