Date: Tue, 12 Dec 2006 06:42:46 -0800 From: Luigi Rizzo <rizzo@icir.org> To: arch@freebsd.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c Message-ID: <20061212064246.A62035@xorpc.icir.org> In-Reply-To: <20061212143113.GA54209@cicely12.cicely.de>; from ticso@cicely12.cicely.de on Tue, Dec 12, 2006 at 03:31:13PM %2B0100 References: <200612081036.kB8AakMD029277@repoman.freebsd.org> <20061212131333.GU54209@cicely12.cicely.de> <20061212055756.A61182@xorpc.icir.org> <20061212141759.GZ54209@cicely12.cicely.de> <20061212062445.A61903@xorpc.icir.org> <20061212143113.GA54209@cicely12.cicely.de>
next in thread | previous in thread | raw e-mail | index | archive | help
[moving to arch] sorry if it has been debated already, but looking in the network code it seems that checks for architectures that need strong alignment are done through a sequence of #if defined(__ia64__) || defined(__blah__) || ... one such sequence is in net/if_loop::if_simloop(), and was related to a problem we are having with some recent commits to net/if_ethersubr.c While the easy fix (for this one) is to add || defined(__arm__) to the sequence, we were wondering if there is some identifier that we can use to the purpose. Bernd Walter was suggesting this: > I would have said ALIGNBYTES != 1, but this also matches with i386. > Guess it's time to introduce somehing like ALIGN_STRONG, or whatever > colour fits best. ideas ? cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061212064246.A62035>