Date: Mon, 7 Feb 2005 19:51:33 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Scott Long <scottl@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c Message-ID: <20050208035133.GA32524@xor.obsecurity.org> In-Reply-To: <200502080343.j183h2Nt041950@repoman.freebsd.org> References: <200502080343.j183h2Nt041950@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Feb 08, 2005 at 03:43:02AM +0000, Scott Long wrote: > scottl 2005-02-08 03:43:02 UTC > > FreeBSD src repository > > Modified files: > sys/dev/twe twe.c twe_freebsd.c > Log: > Fix crashdumps on twe. The twe_immediate_request() path was not only > copying data to a temporary buffer before the I/O, but also copying that > temporary buffer back to the original data location after the I/O. When > you're dumping kernel heap and stack and protected pages, this is very > very bad. > > A belated thanks to Robert Watson for donating hardware for this (and future) > work. Awesome! Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCCDdFWry0BWjoQKURAnfZAJ4iw2XSIFJ62NCGMIMPeWbSzdrkMwCfal3S TNoBoCigtwglIx7bChL9zZ8= =78vD -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050208035133.GA32524>