Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Sep 2017 19:33:37 +0000 (UTC)
From:      Nick Hibma <n_hibma@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r324088 - head/sys/dev/smc
Message-ID:  <201709281933.v8SJXbUo017503@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: n_hibma
Date: Thu Sep 28 19:33:36 2017
New Revision: 324088
URL: https://svnweb.freebsd.org/changeset/base/324088

Log:
  Make this compile with DEVICE_POLLING set.
  
  smc_poll had the wrong prototype. It returns 0 as it does not check
  anything but submits a taskqueue.
  
  Reviewed by:	benno
  MFC after:	2 weeks

Modified:
  head/sys/dev/smc/if_smc.c

Modified: head/sys/dev/smc/if_smc.c
==============================================================================
--- head/sys/dev/smc/if_smc.c	Thu Sep 28 17:55:41 2017	(r324087)
+++ head/sys/dev/smc/if_smc.c	Thu Sep 28 19:33:36 2017	(r324088)
@@ -782,7 +782,7 @@ smc_task_rx(void *context, int pending)
 }
 
 #ifdef DEVICE_POLLING
-static void
+static int
 smc_poll(struct ifnet *ifp, enum poll_cmd cmd, int count)
 {
 	struct smc_softc	*sc;
@@ -792,12 +792,13 @@ smc_poll(struct ifnet *ifp, enum poll_cmd cmd, int cou
 	SMC_LOCK(sc);
 	if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) {
 		SMC_UNLOCK(sc);
-		return;
+		return (0);
 	}
 	SMC_UNLOCK(sc);
 
 	if (cmd == POLL_AND_CHECK_STATUS)
 		taskqueue_enqueue(sc->smc_tq, &sc->smc_intr);
+        return (0);
 }
 #endif
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709281933.v8SJXbUo017503>