Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Nov 2001 13:58:14 -0800
From:      "Bruce A. Mah" <bmah@FreeBSD.org>
To:        Robert Watson <rwatson@FreeBSD.org>
Cc:        Mike Barcroft <mike@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: Committer's guide policy on commit message contents 
Message-ID:  <200111272158.fARLwEp62297@c527597-a.cstvl1.sfba.home.com>
In-Reply-To: <Pine.NEB.3.96L.1011127163632.20120A-100000@fledge.watson.org> 
References:  <Pine.NEB.3.96L.1011127163632.20120A-100000@fledge.watson.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--==_Exmh_-2045023344P
Content-Type: text/plain; charset=us-ascii

If memory serves me right, Robert Watson wrote:
> 
> On Tue, 27 Nov 2001, Mike Barcroft wrote:
> 
> > From the Committers Guide:  "Do not waste space in the commit messages
> > explaining what you did.  That is what cvs diff is for.  Instead, tell
> > us why you did it." 
> 
> Ignoring, for a moment, any context -- I think this is actually not a good
> policy.  In the event that there are complex or large changes being made,
> a brief summary of the changes, along with the rationale, is appropriate
> in the commit message.  At least, that's my feeling :-).  Is this
> something that would be worth changing?

Most emphatically, yes.  If I have to interpret a diff for some random
piece of code just to write a release notes entry, it probably isn't
going to happen.  

Bruce.



--==_Exmh_-2045023344P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: Exmh version 2.3.1+ 05/14/2001

iD8DBQE8BAx22MoxcVugUsMRAurEAJ4wseF+DxZ63C8gOXt1DPmTs9z1cACfQfho
tSSdoBcyy5telK0ZSaHdRug=
=4mUN
-----END PGP SIGNATURE-----

--==_Exmh_-2045023344P--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111272158.fARLwEp62297>