Date: Wed, 4 May 2022 20:16:37 -0600 From: Warner Losh <imp@bsdimp.com> To: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: Massive "Found bio_cmd = 0x5" with options CAM_IOSCHED_DYNAMIC Message-ID: <CANCZdfrV-EyNbNHom%2B_uACh7qEjCxB%2BTEXdiy8BE-ywVYE0w8A@mail.gmail.com> In-Reply-To: <20220505090316.1df9a1bc2e07e69b1da8cb64@dec.sakura.ne.jp>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Sorry for the top post... However, which device(s) are you using? Warner On Wed, May 4, 2022 at 6:03 PM Tomoaki AOKI <junchoon@dec.sakura.ne.jp> wrote: > Hi. > > After updating src main git: f44280bf5fbb to git: 1599fc904d35, > with options CAM_IOSCHED_DYNAMIC on kernel config file, > A plenty of "Found bio_cmd = 0x5" appear on console and dmesg. > > With quick look under src/sys/, bio_cmd = 0x5 means BIO_FLUSH, > and the printf() only appears on src/sys/cam/cam_iosched.c line 1621.[1] > > Maybe it actually wouldn't be harmful (just annoying), but possibly > any conditions blocking BIO_FLUSH to reach there would be lost. > (The printf() itself was already there at git: f44280bf5fbb.) > > If it's actualy not at all harmful, and BIO_FLUSH case is coming > through here is intentional change, is it really needed to be printed? > > There were 4 commits to cam_iosched.c within the span. > > cc1572ddeb8cd82879ce0cca634bf6a8830c0f40 [2] > cam iosched: Remove write bias when read bias = 0 > b65803ba5773d5fb37fa2403105db199569a5811 [3] > cam iosched: default to no read bias in dynamic ioscheduling > d592c0db8ba773c143eeea28610288f800fa651a [4] > cam: add hw.cam.iosched.read_bias > 1599fc904d35cfa8eecad92818d1f4b55de6818f [5] > iosched: Move bio_next() inside of the CAM_IOSCHED_DYNAMIC ifdef > > > [1] https://cgit.freebsd.org/src/tree/sys/cam/cam_iosched.c#n1621 > > [2] > > https://cgit.freebsd.org/src/commit/?id=cc1572ddeb8cd82879ce0cca634bf6a8830c0f40 > > [3] > > https://cgit.freebsd.org/src/commit/?id=b65803ba5773d5fb37fa2403105db199569a5811 > > [4] > > https://cgit.freebsd.org/src/commit/?id=d592c0db8ba773c143eeea28610288f800fa651a > > [5] > > https://cgit.freebsd.org/src/commit/?id=1599fc904d35cfa8eecad92818d1f4b55de6818f > > > Regards. > > -- > Tomoaki AOKI <junchoon@dec.sakura.ne.jp> > [-- Attachment #2 --] <div dir="ltr"><div>Sorry for the top post...</div><div><br></div><div>However, which device(s) are you using?</div><div><br></div><div>Warner<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 4, 2022 at 6:03 PM Tomoaki AOKI <<a href="mailto:junchoon@dec.sakura.ne.jp">junchoon@dec.sakura.ne.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi.<br> <br> After updating src main git: f44280bf5fbb to git: 1599fc904d35,<br> with options CAM_IOSCHED_DYNAMIC on kernel config file,<br> A plenty of "Found bio_cmd = 0x5" appear on console and dmesg.<br> <br> With quick look under src/sys/, bio_cmd = 0x5 means BIO_FLUSH,<br> and the printf() only appears on src/sys/cam/cam_iosched.c line 1621.[1]<br> <br> Maybe it actually wouldn't be harmful (just annoying), but possibly<br> any conditions blocking BIO_FLUSH to reach there would be lost.<br> (The printf() itself was already there at git: f44280bf5fbb.)<br> <br> If it's actualy not at all harmful, and BIO_FLUSH case is coming<br> through here is intentional change, is it really needed to be printed?<br> <br> There were 4 commits to cam_iosched.c within the span.<br> <br> cc1572ddeb8cd82879ce0cca634bf6a8830c0f40 [2]<br> cam iosched: Remove write bias when read bias = 0<br> b65803ba5773d5fb37fa2403105db199569a5811 [3]<br> cam iosched: default to no read bias in dynamic ioscheduling<br> d592c0db8ba773c143eeea28610288f800fa651a [4]<br> cam: add hw.cam.iosched.read_bias<br> 1599fc904d35cfa8eecad92818d1f4b55de6818f [5]<br> iosched: Move bio_next() inside of the CAM_IOSCHED_DYNAMIC ifdef<br> <br> <br> [1] <a href="https://cgit.freebsd.org/src/tree/sys/cam/cam_iosched.c#n1621" rel="noreferrer" target="_blank">https://cgit.freebsd.org/src/tree/sys/cam/cam_iosched.c#n1621</a><br>; <br> [2]<br> <a href="https://cgit.freebsd.org/src/commit/?id=cc1572ddeb8cd82879ce0cca634bf6a8830c0f40" rel="noreferrer" target="_blank">https://cgit.freebsd.org/src/commit/?id=cc1572ddeb8cd82879ce0cca634bf6a8830c0f40</a><br>; <br> [3]<br> <a href="https://cgit.freebsd.org/src/commit/?id=b65803ba5773d5fb37fa2403105db199569a5811" rel="noreferrer" target="_blank">https://cgit.freebsd.org/src/commit/?id=b65803ba5773d5fb37fa2403105db199569a5811</a><br>; <br> [4]<br> <a href="https://cgit.freebsd.org/src/commit/?id=d592c0db8ba773c143eeea28610288f800fa651a" rel="noreferrer" target="_blank">https://cgit.freebsd.org/src/commit/?id=d592c0db8ba773c143eeea28610288f800fa651a</a><br>; <br> [5]<br> <a href="https://cgit.freebsd.org/src/commit/?id=1599fc904d35cfa8eecad92818d1f4b55de6818f" rel="noreferrer" target="_blank">https://cgit.freebsd.org/src/commit/?id=1599fc904d35cfa8eecad92818d1f4b55de6818f</a><br>; <br> <br> Regards.<br> <br> -- <br> Tomoaki AOKI <<a href="mailto:junchoon@dec.sakura.ne.jp" target="_blank">junchoon@dec.sakura.ne.jp</a>><br> </blockquote></div></div>help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrV-EyNbNHom%2B_uACh7qEjCxB%2BTEXdiy8BE-ywVYE0w8A>