Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Aug 2003 20:20:37 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= <des@des.no>
Cc:        Jake Burkholder <jake@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/dev/fb fb.c
Message-ID:  <20030830200408.I3440@gamplex.bde.org>
In-Reply-To: <xzp1xv4cd93.fsf@dwp.des.no>
References:  <200308240242.h7O2g1Eb085767@repoman.freebsd.org> <xzp1xv4cd93.fsf@dwp.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 30 Aug 2003, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote:

> Jake Burkholder <jake@FreeBSD.org> writes:
> >   Log:
> >   Changed ??? to foo in dead code since ??? screws up my editor.
>
> ??? also confuses the compiler ("invalid trigraph blah blah") and
> should be avoided in C code.

Actually, "???" is a valid non-trigraph that doesn't confuse C compilers.
It just sometomes forms a trigraph when mixed with other punctuation.
E.g., "???)" forms the character "?" followed by the trigraph "??)".
So "???)" is converted to "?]" by C compilers.

In fb.c, "???" was followed by ",", so it was just a syntax error (one
of many bugs in the dead code).

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030830200408.I3440>