Date: Wed, 6 Dec 2023 22:50:21 -0700 From: Warner Losh <imp@bsdimp.com> To: Alan Somers <asomers@freebsd.org> Cc: Zhenlei Huang <zlei@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, li-Wen Hsu <lwhsu@freebsd.org> Subject: Re: git: 6b96125afdf2 - main - cap_net.3: remove a copypasta Message-ID: <CANCZdfpzfKdULQ6TjiOt7JaqbghZKjQ9wWphPExMADpuFbQ3qQ@mail.gmail.com> In-Reply-To: <CAOtMX2gvox5qfm8dASpD-4Z3qAqM8v13BRUBs8fKWa98Gm_hpQ@mail.gmail.com> References: <202312061652.3B6GqOuf068349@gitrepo.freebsd.org> <44E8C9F3-84DD-4E51-B2A4-FB56E2A08F30@FreeBSD.org> <CAOtMX2gvox5qfm8dASpD-4Z3qAqM8v13BRUBs8fKWa98Gm_hpQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Dec 6, 2023, 8:59 PM Alan Somers <asomers@freebsd.org> wrote: > On Wed, Dec 6, 2023 at 6:55 PM Zhenlei Huang <zlei@freebsd.org> wrote: > > > > > > > > > On Dec 7, 2023, at 12:52 AM, Alan Somers <asomers@freebsd.org> wrote: > > > > > > The branch main has been updated by asomers: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=6b96125afdf245ae61dd82b59891ad0d6aab0066 > > > > > > commit 6b96125afdf245ae61dd82b59891ad0d6aab0066 > > > Author: Alan Somers <asomers@FreeBSD.org> > > > AuthorDate: 2023-12-05 23:23:29 +0000 > > > Commit: Alan Somers <asomers@FreeBSD.org> > > > CommitDate: 2023-12-06 16:51:37 +0000 > > > > > > cap_net.3: remove a copypasta > > > > > > This line appears to have been copied from cap_sysctl.3. While I'm > > > here, reorder and reword the description of cap_net_limit a bit. > > > > > > [skip ci] > > > > I guess we can 'skip ci' implicitly for document or typo changes. > > Can we? The skipping logic is builtin to Jenkins, Github Workflows, > and Cirrus. I don't think it would be easy to program any of those to > detect which changes can be safely skipped. > The message currently is a nearly nop for our setup. Jenkins runs arent triggered by a commit. Cirrus CI already can't maje it more than a few days into the month. Commits aren't gated into main by CI. So IMHO, it just adds noise. Let's drop it until it has an actual beneficial effect. Metadata like that doesn't really belong in the git log. As this situation changes, we can reevaluate... Again just my opinion... Warner -Alan > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 6, 2023, 8:59 PM Alan Somers <<a href="mailto:asomers@freebsd.org">asomers@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Dec 6, 2023 at 6:55 PM Zhenlei Huang <<a href="mailto:zlei@freebsd.org" target="_blank" rel="noreferrer">zlei@freebsd.org</a>> wrote:<br> ><br> ><br> ><br> > > On Dec 7, 2023, at 12:52 AM, Alan Somers <<a href="mailto:asomers@freebsd.org" target="_blank" rel="noreferrer">asomers@freebsd.org</a>> wrote:<br> > ><br> > > The branch main has been updated by asomers:<br> > ><br> > > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=6b96125afdf245ae61dd82b59891ad0d6aab0066" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=6b96125afdf245ae61dd82b59891ad0d6aab0066</a><br>; > ><br> > > commit 6b96125afdf245ae61dd82b59891ad0d6aab0066<br> > > Author: Alan Somers <asomers@FreeBSD.org><br> > > AuthorDate: 2023-12-05 23:23:29 +0000<br> > > Commit: Alan Somers <asomers@FreeBSD.org><br> > > CommitDate: 2023-12-06 16:51:37 +0000<br> > ><br> > > cap_net.3: remove a copypasta<br> > ><br> > > This line appears to have been copied from cap_sysctl.3. While I'm<br> > > here, reorder and reword the description of cap_net_limit a bit.<br> > ><br> > > [skip ci]<br> ><br> > I guess we can 'skip ci' implicitly for document or typo changes.<br> <br> Can we? The skipping logic is builtin to Jenkins, Github Workflows,<br> and Cirrus. I don't think it would be easy to program any of those to<br> detect which changes can be safely skipped.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">The message currently is a nearly nop for our setup. Jenkins runs arent triggered by a commit. Cirrus CI already can't maje it more than a few days into the month. Commits aren't gated into main by CI. So IMHO, it just adds noise. Let's drop it until it has an actual beneficial effect. Metadata like that doesn't really belong in the git log.</div><div dir="auto"><br></div><div dir="auto">As this situation changes, we can reevaluate...</div><div dir="auto"><br></div><div dir="auto">Again just my opinion...</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> -Alan<br> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpzfKdULQ6TjiOt7JaqbghZKjQ9wWphPExMADpuFbQ3qQ>