Date: Thu, 20 Oct 2011 10:21:25 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r226553 - in head/sys: boot/zfs cddl/boot/zfs Message-ID: <4E9FCBF5.1090000@FreeBSD.org> In-Reply-To: <201110192344.p9JNicuo047731@svn.freebsd.org> References: <201110192344.p9JNicuo047731@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 20/10/2011 02:44 Pawel Jakub Dawidek said the following: > Author: pjd > Date: Wed Oct 19 23:44:38 2011 > New Revision: 226553 > URL: http://svn.freebsd.org/changeset/base/226553 > > Log: > Always pass data size for checksum verification function, as using > physical block size declared in bp may not always be what we want. > For example in case of gang block header physical block size declared > in bp is much larger than SPA_GANGBLOCKSIZE (512 bytes) and checksum > calculation failed. This bug could lead to accessing unallocated > memory and resets/failures during boot. > > MFC after: 3 days I believe that this change is going in the wrong direction. I'd rather prefer that we decreased number of parameters :-) Se my other email. Besides I do not see where we currently really verify checksum of a re-assembled gang block. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E9FCBF5.1090000>