Date: Thu, 23 Feb 2012 20:43:31 +0530 From: "Jayachandran C." <jchandra@freebsd.org> To: Rafal Jaworowski <raj@semihalf.com> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r232028 - in user/jchandra/xlp-merge/sys: conf dev/iicbus Message-ID: <CA%2B7sy7B=U4XOPALhW0Lctgu1DzafJu-YX=S7uFO%2BychmA1m8tA@mail.gmail.com> In-Reply-To: <BB34482C-89CF-467B-BCB6-6A4488947A6A@semihalf.com> References: <201202230536.q1N5anOF086049@svn.freebsd.org> <BB34482C-89CF-467B-BCB6-6A4488947A6A@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 23, 2012 at 7:42 PM, Rafal Jaworowski <raj@semihalf.com> wrote: > > On 2012-02-23, at 06:36, Jayachandran C. wrote: > >> Author: jchandra >> Date: Thu Feb 23 05:36:49 2012 >> New Revision: 232028 >> URL: http://svn.freebsd.org/changeset/base/232028 >> >> Log: >> =A0Move driver for DS1374 RTC to sys/dev/iicbus >> >> =A0The earlier version of the driver was sys/mips/rmi/dev/iic/ds1374u.c > > Is the DS1374 very different from other DS13xx chips? > > We have some patches locally that extend the current DS133x into DS13xx i= .e. support also DS1388 for example, so I was wondering if the DS1374 could= be just squeezed in as well? See http://people.freebsd.org/~raj/patches/mi= sc/ds13xx.diff I had a quick look at the datasheets, the 1374 registers uses a time of day counter, while the 133x uses a BCD coded date representation. The other features which we do not support now(alarm/watchdog etc) also seems different, so merging the drivers may not result in reducing code. JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B7sy7B=U4XOPALhW0Lctgu1DzafJu-YX=S7uFO%2BychmA1m8tA>