Date: Fri, 21 Feb 2014 19:48:53 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: vbox@FreeBSD.org Subject: Re: emulators/virtualbox-ose doesn't compile with libiconv Message-ID: <20140221194853.277adcb9@kalimero.tijl.coosemans.org> In-Reply-To: <530796B0.5040100@FreeBSD.org> References: <20140210191712.728e1b7d@s100.slimaczek.pl> <20140221170046.07c87bce@kalimero.tijl.coosemans.org> <20140221174251.72fa8e74@kalimero.tijl.coosemans.org> <530796B0.5040100@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Feb 2014 13:10:56 -0500 Jung-uk Kim wrote: > On 2014-02-21 11:42:51 -0500, Tijl Coosemans wrote: >> On Fri, 21 Feb 2014 17:00:46 +0100 Tijl Coosemans wrote: >>> On Mon, 10 Feb 2014 19:17:12 +0100 Tomasz Sowa wrote: >>>> emulators/virtualbox-ose doesn't compile when >>>> converters/libiconv is installed: >>> >>> Please try the attached patch for the port Makefile. >> >> Sorry, that one was incomplete. This one should work better. > > Actually, I fixed it in my tree little differently. > > https://redports.org/changeset?reponame=&new=23380%40jkim%2Femulators&old=22447%40jkim%2Femulators As long as you define LIBICONV_PLUG or replace <iconv.h> with </usr/include/iconv.h> you're fine. I would define LIBICONV_PLUG only if ICONV_LIB is empty though so you always use libiconv_open and libiconv_close etc. with libiconv. iconv_open and iconv_close work with libiconv too but they are also what base iconv uses so there's a higher risk of trouble.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140221194853.277adcb9>