Date: Fri, 04 Oct 2024 05:34:41 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port Message-ID: <1c5e55cb722998c9eff8345c43853aee@mail.infomaniak.com> In-Reply-To: <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75> References: <202410011223.491CNu6S051590@gitrepo.freebsd.org> <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-10-02T09:21:13.000+02:00, Pietro Cerutti <gahr@FreeBSD.org> wrote: > On Oct 01 2024, 17:04 +0000, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote: >> Please review Porters Handbook, there are several "guidelines" to >> make >> >> the tree more consistent and reducing overall workload. > > I have pushed a few cleanups in > 771ce8599db53660f3aa7c1e31dba1c87852586c. Thanks! >>> PORTVERSION --> DISTVERSION >> >> https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github >> >> ...and stray(?) comment? > > Thanks, corrected. > >> Correct maintainer? There's no reference and from what I can tell >> no >> >> submitted PR in Bugzilla. > > The maintainer is correct. It's a person I know and the port was > > submitted to me privately. I didn't think anyone would want it > > publicized it in the commit message. Just add something like "submitted via private email" or something similar so it's clear of origin >> libxml2 dependency should use the GNOME helper >> >> https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome >> >> https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components >> >> sqlite3 dependency should also use a helper >> >> https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses >> >> CMAKE_ARGS can be replaced with CMAKE_OFF= ENABLE_PYTHON >> >> https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake > > Thanks, corrected. > >> do-test section can be replaced with USES= cmake:testing >> >> https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20 > > I wasn't able to do it with cmake:testing. Were you? Upstream uses from what I can tell an rather old approach for test target, https://github.com/rpm-software-management/createrepo_c/blob/master/CMakeLists.txt#L160 The "EXCLUDE FROM ALL" part is what causes the issue >> Poudriere also lists quite a few warnings about dependencies and >> the >> >> REINPLACE_CMD commands. >> >>> https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log > > Nice. I wasn't aware of poudriere's Q/A phase. I used poudriere bulk > to > > test the port but I don't see that in my logs. How do I enable it? > > https://gahr.ch/poudriere/logs/bulk/14amd64-dev/2024-10-01_12h26m54s/logs/createrepo_c-1.1.4.log > > Also, I have run `portlint -AC` multiple times as I was reviewing > the > > port, and it was happy with what I had. > > Yeah, I should skim through the handbook once in a while. I've been > > doing ports for a long time and I am probably missing out on the > latest > > enhancements and developments. > >> It also seems to look for Doxygen by default >> >> which you probably want to disable to avoid potential plist >> issues. > > Well, they don't provide a way to turn off docs, but I don't see an > > issue with it building docs if it finds doxygen. We won't be > installing > > them anyway. https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html works :-) > -- > > Pietro Cerutti > > I have pledged to give 10% of income to effective charities > > and invite you to join me - https://givingwhatwecan.org I've hacked together a patch doing the final cleanups which fixes the Q/A issues. I've also left a comment in one of the submitted PRs as it breaks build if optional dependencies are disabled. https://pdr2.bofh.network/data/141-diizzy/2024-10-03_21h47m26s/logs/createrepo_c-1.1.4.log (testport) https://pdr2.bofh.network/data/133-diizzy/2024-10-03_22h05m43s/logs/createrepo_c-1.1.4.log (bulk) Not sure why your Podriere doesn't run QA on bulk builds :-/ Patch: https://projects.pyret.net/files/freebsd-patches/createrepo_c-improve.patch Best regards, Daniel [-- Attachment #2 --] <html><body><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">On 2024-10-02T09:21:13.000+02:00, Pietro Cerutti <gahr@FreeBSD.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>On Oct 01 2024, 17:04 +0000, Daniel Engberg <<a class="defaultMailLink" href="mailto:daniel.engberg.lists@pyret.net">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><blockquote class="ws-ng-quote"><div> Please review Porters Handbook, there are several "guidelines" to make<br></div><div>the tree more consistent and reducing overall workload.<br></div></blockquote><div> <br></div><div>I have pushed a few cleanups in 771ce8599db53660f3aa7c1e31dba1c87852586c.<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Thanks!<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div><br></div><div><br></div><blockquote class="ws-ng-quote"><div> <br></div><blockquote class="ws-ng-quote"> PORTVERSION --> DISTVERSION<br></blockquote><div> <br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github</a><br></div><div><br></div><div>...and stray(?) comment?<br></div></blockquote><div> <br></div><div>Thanks, corrected.<br></div><div><br></div><blockquote class="ws-ng-quote"><div> Correct maintainer? There's no reference and from what I can tell no<br></div><div>submitted PR in Bugzilla.<br></div></blockquote><div> <br></div><div>The maintainer is correct. It's a person I know and the port was <br></div><div>submitted to me privately. I didn't think anyone would want it <br></div><div>publicized it in the commit message.<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Just add something like "submitted via private email" or something similar so it's clear of origin<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div><br></div><div><br></div><blockquote class="ws-ng-quote"><div> libxml2 dependency should use the GNOME helper<br></div><div><br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome</a><br></div><div><br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components</a><br></div><div><br></div><div>sqlite3 dependency should also use a helper<br></div><div><br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses</a><br></div><div><br></div><div>CMAKE_ARGS can be replaced with CMAKE_OFF= ENABLE_PYTHON<br></div><div><br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake</a><br></div></blockquote><div>; <br></div><div>Thanks, corrected.<br></div><div><br></div><blockquote class="ws-ng-quote"><div> do-test section can be replaced with USES= cmake:testing<br></div><div><br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20" target="_blank">https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20</a><br></div></blockquote><div>; <br></div><div>I wasn't able to do it with cmake:testing. Were you?<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Upstream uses from what I can tell an rather old approach for test target,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://github.com/rpm-software-management/createrepo_c/blob/master/CMakeLists.txt#L160">https://github.com/rpm-software-management/createrepo_c/blob/master/CMakeLists.txt#L160</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">The "EXCLUDE FROM ALL" part is what causes the issue<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div><br></div><div><br></div><blockquote class="ws-ng-quote"><div> Poudriere also lists quite a few warnings about dependencies and the<br></div><div>REINPLACE_CMD commands. <br></div><blockquote class="ws-ng-quote"> <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log" target="_blank">https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log</a><br></blockquote></blockquote><div>; <br></div><div>Nice. I wasn't aware of poudriere's Q/A phase. I used poudriere bulk to <br></div><div>test the port but I don't see that in my logs. How do I enable it?<br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://gahr.ch/poudriere/logs/bulk/14amd64-dev/2024-10-01_12h26m54s/logs/createrepo_c-1.1.4.log" target="_blank">https://gahr.ch/poudriere/logs/bulk/14amd64-dev/2024-10-01_12h26m54s/logs/createrepo_c-1.1.4.log</a><br></div><div><br></div><div>Also, I have run `portlint -AC` multiple times as I was reviewing the <br></div><div>port, and it was happy with what I had.<br></div><div><br></div><div>Yeah, I should skim through the handbook once in a while. I've been <br></div><div>doing ports for a long time and I am probably missing out on the latest <br></div><div>enhancements and developments.<br></div><div><br></div><blockquote class="ws-ng-quote"><div> It also seems to look for Doxygen by default<br></div><div>which you probably want to disable to avoid potential plist issues.<br></div></blockquote><div> <br></div><div>Well, they don't provide a way to turn off docs, but I don't see an <br></div><div>issue with it building docs if it finds doxygen. We won't be installing <br></div><div>them anyway.<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html">https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html</a>; works :-)<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div><br></div><div><br></div><div>-- <br></div><div>Pietro Cerutti<br></div><div>I have pledged to give 10% of income to effective charities<br></div><div>and invite you to join me - <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://givingwhatwecan.org" target="_blank">https://givingwhatwecan.org</a><br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">I've hacked together a patch doing the final cleanups which fixes the Q/A issues.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">I've also left a comment in one of the submitted PRs as it breaks build if optional dependencies are disabled.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://pdr2.bofh.network/data/141-diizzy/2024-10-03_21h47m26s/logs/createrepo_c-1.1.4.log">https://pdr2.bofh.network/data/141-diizzy/2024-10-03_21h47m26s/logs/createrepo_c-1.1.4.log</a>; (testport)<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://pdr2.bofh.network/data/133-diizzy/2024-10-03_22h05m43s/logs/createrepo_c-1.1.4.log">https://pdr2.bofh.network/data/133-diizzy/2024-10-03_22h05m43s/logs/createrepo_c-1.1.4.log</a>; (bulk)<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Not sure why your Podriere doesn't run QA on bulk builds :-/<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Patch:<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://projects.pyret.net/files/freebsd-patches/createrepo_c-improve.patch">https://projects.pyret.net/files/freebsd-patches/createrepo_c-improve.patch</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best regards,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Daniel<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1c5e55cb722998c9eff8345c43853aee>