Date: Sun, 12 Feb 2017 21:47:57 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 217051] [PATCH] multimedia/vlc: Build in C++11 mode by default Message-ID: <bug-217051-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217051 Bug ID: 217051 Summary: [PATCH] multimedia/vlc: Build in C++11 mode by default Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: multimedia@FreeBSD.org Reporter: rakuco@FreeBSD.org CC: multimedia@FreeBSD.org, riggs@FreeBSD.org Blocks: 216797 Attachment #179920 maintainer-approval?(multimedia@FreeBSD.org) Flags: Keywords: patch Flags: maintainer-feedback?(multimedia@FreeBSD.org) CC: multimedia@FreeBSD.org Created attachment 179920 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179920&action=edit Proposed patch This is in preparation for the Qt 5.6.2 -> 5.7.1 update (bug 216797): Qt 5.7 requires C++11 support. VLC 2.2.4 has issues building in C++11 mode, so incorporate a few upstream commits to make things work, and adjust the atomics-related patches landed in ports r416225, as including <atomic> only with libc++ >= 3.8.0 leaves out FreeBSD 10.3. include/vlc_atomic.h is now closer to its git (post-2.2.4) version, in that we now have 3 possible conditions: 1. The header is included in C11 mode, in which case <stdatomic.h> is included. 2. The header is included by C code but we're not building in C11 mode, in which case some shims are defined. 3. The header is included by C++ code, so we can assume C++11 and just include <atomic>. It will likely be possible to drop the changes once a new VLC version is released, as upstream has since started requiring C+11 and passes the appropriate flags to the compiler. Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216797 [Bug 216797] [exp-run] update Qt to 5.7.1, move Qt4 binaries and rename ports -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217051-12827>