Date: Wed, 30 Nov 2016 19:07:57 -0800 From: Ngie Cooper <yaneurabeya@gmail.com> To: "Conrad E. Meyer" <cem@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309344 - head/lib/libutil Message-ID: <4DFE017D-90FD-44F4-8FE7-7EE53D499F7B@gmail.com> In-Reply-To: <201612010221.uB12Lb6x067202@repo.freebsd.org> References: <201612010221.uB12Lb6x067202@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Nov 30, 2016, at 18:21, Conrad E. Meyer <cem@FreeBSD.org> wrote: >=20 > Author: cem > Date: Thu Dec 1 02:21:36 2016 > New Revision: 309344 > URL: https://svnweb.freebsd.org/changeset/base/309344 >=20 > Log: > Remove a death threat from the FreeBSD sources >=20 > Reported by: koobs@, araujo@, linimon@, bjk@, emaste@, jhb@, ngie@, ce= m@ > Maintainer timeout: des@ Really?? I wish you hadn't added me to this list.. I don't in any way endors= e the way that you went about dealing with this disagreement. You kind of ju= st pissed all over what des@ did out of spite. </rant> > Modified: > head/lib/libutil/flopen.c >=20 > Modified: head/lib/libutil/flopen.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/lib/libutil/flopen.c Thu Dec 1 01:56:34 2016 (r309343) > +++ head/lib/libutil/flopen.c Thu Dec 1 02:21:36 2016 (r309344) > @@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$"); > /* > * Reliably open and lock a file. > * > - * DO NOT, UNDER PAIN OF DEATH, modify this code without first reading th= e > - * revision history and discussing your changes with <des@freebsd.org>. > - * Don't be fooled by the code's apparent simplicity; there would be no > - * need for this function if it was as easy to get right as you think. > + * Please do not modify this code without first reading the revision hist= ory > + * and discussing your changes with <des@freebsd.org>. Don't be fooled b= y the > + * code's apparent simplicity; there would be no need for this function i= f it > + * was easy to get right. > */ > int > flopen(const char *path, int flags, ...) > @@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...) > errno =3D serrno; > return (-1); > } > -#ifdef DONT_EVEN_THINK_ABOUT_IT > + /* > + * The following change is provided as a specific example to > + * avoid. > + */ > +#if 0 > if (fcntl(fd, F_SETFD, FD_CLOEXEC) !=3D 0) { > serrno =3D errno; > (void)close(fd); >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DFE017D-90FD-44F4-8FE7-7EE53D499F7B>