Date: Sat, 30 Nov 2024 16:51:18 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 0c293d0425a7 - stable/14 - md5: Consistently use item count as the first argument to calloc Message-ID: <202411301651.4AUGpIKS043851@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=0c293d0425a7d87e367c77ced644b2f1150afd7d commit 0c293d0425a7d87e367c77ced644b2f1150afd7d Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2024-07-19 17:04:27 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2024-11-30 13:55:57 +0000 md5: Consistently use item count as the first argument to calloc Reported by: GCC 14 -Wcalloc-transposed-args Reviewed by: rlibby Differential Revision: https://reviews.freebsd.org/D46009 (cherry picked from commit e8e2ab3c55228d66388a0b33de8c5ac4b3d6dbe9) --- sbin/md5/md5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/md5/md5.c b/sbin/md5/md5.c index 1bf897d119c0..b8afa736e229 100644 --- a/sbin/md5/md5.c +++ b/sbin/md5/md5.c @@ -593,7 +593,7 @@ main(int argc, char *argv[]) while (argc--) gnu_check(*argv++); argc = 0; - argv = calloc(sizeof(char *), numrecs + 1); + argv = calloc(numrecs + 1, sizeof(char *)); for (rec = head; rec != NULL; rec = rec->next) { argv[argc] = rec->filename; argc++;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202411301651.4AUGpIKS043851>