Date: Mon, 22 Aug 2016 07:17:46 +0000 From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D7593: net/rndis: Add canonical RNDIS major/minor version as of today. Message-ID: <differential-rev-PHID-DREV-ukhjohui6ezrkecptveh-req@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: hselasky, glebius, bz, gnn, rwatson. sepherosa_gmail.com added a subscriber: freebsd-net-list. REVISION DETAIL https://reviews.freebsd.org/D7593 AFFECTED FILES sys/dev/usb/net/if_urndis.c sys/net/rndis.h CHANGE DETAILS diff --git a/sys/net/rndis.h b/sys/net/rndis.h --- a/sys/net/rndis.h +++ b/sys/net/rndis.h @@ -23,6 +23,10 @@ #ifndef _NET_RNDIS_H_ #define _NET_RNDIS_H_ +/* Canonical major/minor version as of 22th Aug. 2016. */ +#define RNDIS_VERSION_MAJOR 0x00000001 +#define RNDIS_VERSION_MINOR 0x00000000 + #define RNDIS_STATUS_BUFFER_OVERFLOW 0x80000005L #define RNDIS_STATUS_FAILURE 0xC0000001L #define RNDIS_STATUS_INVALID_DATA 0xC0010015L diff --git a/sys/dev/usb/net/if_urndis.c b/sys/dev/usb/net/if_urndis.c --- a/sys/dev/usb/net/if_urndis.c +++ b/sys/dev/usb/net/if_urndis.c @@ -658,7 +658,7 @@ msg.rm_type = htole32(REMOTE_NDIS_INITIALIZE_MSG); msg.rm_len = htole32(sizeof(msg)); msg.rm_rid = 0; - msg.rm_ver_major = htole32(1); + msg.rm_ver_major = htole32(RNDIS_VERSION_MAJOR); msg.rm_ver_minor = htole32(1); msg.rm_max_xfersz = htole32(RNDIS_RX_MAXLEN); EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, hselasky, glebius, bz, gnn, rwatson Cc: freebsd-net-list [-- Attachment #2 --] diff --git a/sys/net/rndis.h b/sys/net/rndis.h --- a/sys/net/rndis.h +++ b/sys/net/rndis.h @@ -23,6 +23,10 @@ #ifndef _NET_RNDIS_H_ #define _NET_RNDIS_H_ +/* Canonical major/minor version as of 22th Aug. 2016. */ +#define RNDIS_VERSION_MAJOR 0x00000001 +#define RNDIS_VERSION_MINOR 0x00000000 + #define RNDIS_STATUS_BUFFER_OVERFLOW 0x80000005L #define RNDIS_STATUS_FAILURE 0xC0000001L #define RNDIS_STATUS_INVALID_DATA 0xC0010015L diff --git a/sys/dev/usb/net/if_urndis.c b/sys/dev/usb/net/if_urndis.c --- a/sys/dev/usb/net/if_urndis.c +++ b/sys/dev/usb/net/if_urndis.c @@ -658,7 +658,7 @@ msg.rm_type = htole32(REMOTE_NDIS_INITIALIZE_MSG); msg.rm_len = htole32(sizeof(msg)); msg.rm_rid = 0; - msg.rm_ver_major = htole32(1); + msg.rm_ver_major = htole32(RNDIS_VERSION_MAJOR); msg.rm_ver_minor = htole32(1); msg.rm_max_xfersz = htole32(RNDIS_RX_MAXLEN);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?differential-rev-PHID-DREV-ukhjohui6ezrkecptveh-req>