Date: Tue, 23 Mar 2021 19:28:27 +0100 From: tuexen@freebsd.org To: Kevin Bowling <kevin.bowling@kev009.com> Cc: FreeBSD Net <freebsd-net@freebsd.org>, rscheff@freebsd.org Subject: Re: tcp-testsuite into src? Message-ID: <8F452EAE-9A63-4359-A16A-9FA0A369B981@freebsd.org> In-Reply-To: <CAK7dMtB%2B=Ydo4ziznKxj7qV6TsDUH7EzXbeyj0ZT1=zuJDhD=A@mail.gmail.com> References: <CAK7dMtB%2B=Ydo4ziznKxj7qV6TsDUH7EzXbeyj0ZT1=zuJDhD=A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 23. Mar 2021, at 02:31, Kevin Bowling <kevin.bowling@kev009.com> wrote: > > Hi, > > I was talking with gnn and kevans on IRC about the tcp testsuite > (https://github.com/freebsd-net/tcp-testsuite). > > Currently we maintain this in ports, although the way the port is set > up doesn't make a lot of sense because the tests are stack specific > and we don't account for different FreeBSD versions let alone vendor Just to be clear: * The tests only work with FreeBSD head/master/main. * The current tests should work with the freebsd, the rack and bbr stack. However, the tests sometimes need updates to reflect code changes. > trees. It seems reasonable to me to pull the tests themselves (i.e. > https://github.com/freebsd-net/tcp-testsuite) into src where they can > follow along with the tree they are running on, and provide vendors a > natural point of extension. I'm happy to have them in the src repo. That way it would be possible to also support stable/13 and (possibly) stable/12. > > /usr/tests has some existing examples of relying on out of tree > binaries to run so I am not convinced we need to import packetdrill > itself but I don't have a strong preference. tuexen, do you have any > preference? No. Just as a note. There do also exist SCTP tests and I had sometime ago some UDP lite tests. So we might want to have a directory layout supporting multiple protocols. Best regards Michael > > Regards, > Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8F452EAE-9A63-4359-A16A-9FA0A369B981>