Date: Sun, 28 Nov 2010 15:12:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Philip M. Gollucci" <pgollucci@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www Makefile ports/www/py-flask Makefile distinfo pkg-descr pkg-plist Message-ID: <20101128151252.GA717@FreeBSD.org> In-Reply-To: <201011270200.oAR20vwO042200@repoman.freebsd.org> References: <201011270200.oAR20vwO042200@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 27, 2010 at 02:00:57AM +0000, Philip M. Gollucci wrote: > pgollucci 2010-11-27 02:00:57 UTC > > FreeBSD ports repository > > Modified files: > www Makefile > Added files: > www/py-flask Makefile distinfo pkg-descr pkg-plist > Log: > Flask is a microframework for Python based on Werkzeug and Jinja 2. > > WWW: http://flask.pocoo.org/ > > PR: ports/151625 > Submitted by: Olivier Duchateau <duchateau.olivier at gmail.com> Ugh, I think I've reviewed this submission, but it still was committed with lots of bugs: - PORTNAME should be `flask', not `Flask' - Makefile header is severely badly indented (and if you wanted to use `Flask', that's the right place, instead of `py-flask' which merely mimics the port directory name) - Missing leading tab in the second line of RUN_DEPENDS - LICENSE should be placed after COMMENT - In port description, tab after WWW: should be space - COMMENT should start with capital letter Also, port description is very scarse; right now it merely repeats the COMMENT, while it should give some extensive information so that people should not have to visit the website to find out what is this port for and about. Please fix, thanks. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101128151252.GA717>