Date: Tue, 03 Sep 2019 14:07:36 -0000 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Justin Hibbits <chmeeedalf@gmail.com>, Alan Somers <asomers@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf Message-ID: <CANCZdfpCTWO3=kcxsnL3zvFsx8naR5K97yodmCaqpx0298Qcgg@mail.gmail.com> In-Reply-To: <b55dfa92-ef79-3204-f832-ea17688f1e76@FreeBSD.org> References: <201904201251.x3KCp6it044898@repo.freebsd.org> <CAHSQbTDfj5_-N69UyCpdfqAH=vAW%2BUA3C%2Bm%2BPyBXYsmxEZQOGg@mail.gmail.com> <CAOtMX2jPjfmMJz-Mbw7-Dti=YsTHLj%2BH3BEiX3Xr1NZza0HPAg@mail.gmail.com> <CAHSQbTAnsvNvzKABdXpXFtoWhV%2BcoK6oqJctzJodfYALz2_tgA@mail.gmail.com> <5bf4a702-7df8-5597-25b0-55baa71d1d4f@FreeBSD.org> <CANCZdfq=ujXKFj8dXTFLNrONRqcvntn0mDMpFL-eZafvq4=F%2BQ@mail.gmail.com> <b55dfa92-ef79-3204-f832-ea17688f1e76@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 20, 2019 at 2:03 PM John Baldwin <jhb@freebsd.org> wrote: > On 4/20/19 10:21 AM, Warner Losh wrote: > > On Sat, Apr 20, 2019, 10:44 AM John Baldwin <jhb@freebsd.org> wrote: > > > >> On 4/20/19 6:23 AM, Justin Hibbits wrote: > >>> On Sat, Apr 20, 2019, 08:21 Alan Somers <asomers@freebsd.org> wrote: > >>> > >>>> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits <chmeeedalf@gmail.com> > >>>> wrote: > >>>>> > >>>>> > >>>>> > >>>>> On Sat, Apr 20, 2019, 07:51 Alan Somers <asomers@freebsd.org> wrote: > >>>>>> > >>>>>> Author: asomers > >>>>>> Date: Sat Apr 20 12:51:05 2019 > >>>>>> New Revision: 346441 > >>>>>> URL: https://svnweb.freebsd.org/changeset/base/346441 > >>>>>> > >>>>>> Log: > >>>>>> Use symlinks for kernel modules rather than hardlinks > >>>>>> > >>>>>> When aliasing a kernel module to a different name (ie if_igb for > >>>> if_em), > >>>>>> it's better to use symlinks than hard links. kldxref will omit > >>>> entries for > >>>>>> the links, ensuring that the loaded module has the correct name. > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> Thanks! This should fix installkernel on my POWER9. > >>>>> > >>>>> - Justin > >>>> > >>>> What's the problem with your POWER9? Is that one of those msdosfs > >>>> /boot systems? If so, I don't think this will fix it. msdosfs > >>>> doesn't support either symlinks or hardlinks. Or is there some other > >>>> problem? > >>>> -Alan > >>>> > >>> > >>> Yes it is. Well that's a bummer then. I thought we faked symlinks on > >>> msdosfs, but on second thought not sure how well would do that. > >> > >> You could just use cp instead of a link? > >> > > > > I don't think this solves the original issue. > > FWIW, I think igb and em still use separate driver_t's with separate > probe tables, etc. to preserve POLA of existing device names, so in > theory there could still be two modules, it's just by choice that they > are both in the same C file and same kld. > Yea, I sometimes wish they'd have if_em.ko that's just this table and a dependency to igb.ko plus another if_igb.ko with the same dependency. That would be cleaner than the hacky thing we're doing which forces us to have other hacks in kldload, etc. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpCTWO3=kcxsnL3zvFsx8naR5K97yodmCaqpx0298Qcgg>