Date: Sun, 28 Jun 2009 13:37:39 GMT From: Alexander Motin <mav@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 165346 for review Message-ID: <200906281337.n5SDbdDd023297@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=165346 Change 165346 by mav@mav_mavbook on 2009/06/28 13:37:33 Do not drop the lock at the end of atapi_action() on error. It is the real reason of crash when ATA XPT tried to scan this emulated SPI bus. Affected files ... .. //depot/projects/scottl-camlock/src/sys/dev/ata/atapi-cam.c#16 edit Differences ... ==== //depot/projects/scottl-camlock/src/sys/dev/ata/atapi-cam.c#16 (text+ko) ==== @@ -666,13 +666,11 @@ xpt_freeze_simq(sim, /*count*/ 1); ccb_h->status = CAM_REQUEUE_REQ; xpt_done(ccb); - mtx_unlock(&softc->state_lock); return; action_invalid: ccb_h->status = CAM_REQ_INVALID; xpt_done(ccb); - mtx_unlock(&softc->state_lock); return; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906281337.n5SDbdDd023297>