Date: Tue, 20 Jan 2015 01:14:46 +0100 From: Willem Jan Withagen <wjw@digiware.nl> To: Garrett Cooper <yaneurabeya@gmail.com>, Brandon Allbery <allbery.b@gmail.com> Cc: mexas@bris.ac.uk, rmacklem@uoguelph.ca, freebsd-stable <freebsd-stable@freebsd.org>, freebsd current <freebsd-current@freebsd.org> Subject: Re: old bug: mount_nfs path/name is limited to 88 chars Message-ID: <54BD9DF6.8060402@digiware.nl> In-Reply-To: <99F7DA1A-66EB-4F69-BAFA-0D72E4207248@gmail.com> References: <1401700998.16283447.1421681564732.JavaMail.root@uoguelph.ca> <201501191544.t0JFiP7O027952@mech-as221.men.bris.ac.uk> <CAKFCL4Vv5Uf7p737uE-riDBw57KTJ7r7QSmn7Bj7i=gn1yo5UA@mail.gmail.com> <99F7DA1A-66EB-4F69-BAFA-0D72E4207248@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19-1-2015 22:20, Garrett Cooper wrote: > On Jan 19, 2015, at 8:46, Brandon Allbery <allbery.b@gmail.com> > wrote: > >> On Mon, Jan 19, 2015 at 10:44 AM, Anton Shterenlikht >> <mexas@bris.ac.uk> wrote: >> >>> So perhaps changing MNAMELEN will break statfs(2) on -stable >>> too? >>> >> >> I believe the context there is not so much "-current is special", >> as "changing it for everyone is bad news" (and this would >> necessarily need to originate in -current). > > A compat layer needs to be created for all of the affected syscalls, > and the change needs to be made. That’s it in a nutshell. > > Doing it in 11 makes sense since there is a compat layer for 10 now… > if I knew all of the steps I would happily do them as annoys me from > time to time as well with the path length issue. Well after this the next problem you'll be running into is: #define PATH_MAX 1024 /* max bytes in pathname */ Which I already did inf find(1) because the paths in backups of big filesystems already bit in like 2011. Talked about it with Jilles, and got more or less the same answer: You can up the value, but expect things to break. Which it did when I only fixed the size in find. It would break in the program that got the path fed. Never dared to just up the value, compile kernel/world, install and reboot. And then see what comes of it. So IMHO if possible this would need to be extended as well... --WjW
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54BD9DF6.8060402>