Date: Thu, 17 Sep 2009 11:56:20 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Henrik Brix Andersen <brix@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Renato Botelho <garga@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/irc/bitlbee/files bitlbee.in Message-ID: <4AB28654.4090706@FreeBSD.org> In-Reply-To: <200909131035.n8DAZND8097060@repoman.freebsd.org> References: <200909131035.n8DAZND8097060@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Henrik Brix Andersen wrote:
> brix 2009-09-13 10:35:23 UTC
>
> FreeBSD ports repository
>
> Modified files:
> irc/bitlbee/files bitlbee.in
> Log:
> - Use -u ${user} option to bitlbee instead of su in rc.d script
>
> PR: ports/138268 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=138268
> Submitted by: garga
>
> Revision Changes Path
> 1.4 +2 -2 ports/irc/bitlbee/files/bitlbee.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/bitlbee/files/bitlbee.in.diff?&r1=1.3&r2=1.4&f=h
With this change the script can be further simplified as attached.
LOGIN is needed instead of DAEMON since it's running as a specific
user. We also generally prefer that ports stuff uses LOGIN unless
something earlier is needed.
hth,
Doug
--
This .signature sanitized for your protection
[-- Attachment #2 --]
--- /usr/ports/irc/bitlbee/files/bitlbee.in 2009-09-14 13:04:11.000000000 -0700
+++ bitlbee.in 2009-09-17 11:53:39.000000000 -0700
@@ -3,7 +3,7 @@
# $FreeBSD: ports/irc/bitlbee/files/bitlbee.in,v 1.4 2009/09/13 10:35:23 brix Exp $
#
# PROVIDE: bitlbee
-# REQUIRE: DAEMON
+# REQUIRE: LOGIN
# KEYWORD: shutdown
# Add the following lines to /etc/rc.conf to enable bitlbee:
@@ -23,12 +23,6 @@
required_files="${bitlbee_config}"
command="%%PREFIX%%/sbin/bitlbee"
-start_cmd="bitlbee_start"
-
-bitlbee_start()
-{
- echo "Starting ${name}."
- ${command} -D -u ${bitlbee_user} -c ${bitlbee_config} ${bitlbee_flags}
-}
+command_args="-D -u ${bitlbee_user} -c ${bitlbee_config}"
run_rc_command "$1"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AB28654.4090706>