Date: Fri, 26 Oct 2007 11:36:54 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/common ufsread.c Message-ID: <200710261136.54938.jhb@freebsd.org> In-Reply-To: <200710261500.l9QF0ZJ0036161@repoman.freebsd.org> References: <200710261500.l9QF0ZJ0036161@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 26 October 2007 11:00:34 am Warner Losh wrote: > imp 2007-10-26 15:00:34 UTC > > FreeBSD src repository > > Modified files: > sys/boot/common ufsread.c > Log: > The arm boot code uses this function as well. Redefining cgbase() > saves about 500 bytes in the boot code. While the AT91RM9200 has 12k > of space for the boot loader, which is more than i386's 8k, the code > generated by gcc is a bit bigger. > > I've had this in p4 for about two years now. > > Revision Changes Path > 1.16 +1 -1 src/sys/boot/common/ufsread.c > We should probably change this to be #ifdef SMALL_CGBASE or some such then and just define it before ufsread.c in boot2.c and other files that include it. Does that sound ok to you (or do you have a better name?) UFS_SMALL_CGBASE maybe? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710261136.54938.jhb>