Date: Wed, 07 Feb 2001 06:33:48 -0800 From: Peter Wemm <peter@netplex.com.au> To: Cameron Grant <cg@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Broken PCM - Re: cvs commit: src/sys/dev/sound/pcm channel.c Message-ID: <200102071433.f17EXmt64539@mobile.wemm.org> In-Reply-To: <200102070648.f176mTJ68070@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Cameron Grant wrote:
> cg 2001/02/06 22:48:29 PST
>
> Modified files:
> sys/dev/sound/pcm channel.c
> Log:
> conditionalize "hwptr went backwards" messages
>
> modify default buffer size heuristic to not max out at 4k. mpg123 should n
ow
> behave better under load.
>
> Revision Changes Path
> 1.49 +430 -806 src/sys/dev/sound/pcm/channel.c
I dont think you meant to commit all this stuff.. It breaks the kernel
pretty badly. pcm_channel doesn't have the mutexes yet.
Your MFC said "merge rev 1.49" which was a couple of lines at the most, so
I think you accidently committed this stuff. I backed out the change locally
and hand-applied the MFC'ed patches to rev 1.48 and it seems to work fine.
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102071433.f17EXmt64539>