Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 04 Sep 2009 10:51:48 -0700
From:      Julian Elischer <julian@elischer.org>
To:        "Bjoern A. Zeeb" <bz@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, Konstantin Belousov <kib@FreeBSD.org>
Subject:   Re: svn commit: r196829 - head/sys/i386/i386
Message-ID:  <4AA153B4.4050408@elischer.org>
In-Reply-To: <4AA15257.4050305@elischer.org>
References:  <200909041453.n84ErCtU075966@svn.freebsd.org> <20090904145527.S68375@maildrop.int.zabbadoz.net> <4AA15257.4050305@elischer.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote:
> Bjoern A. Zeeb wrote:
>> On Fri, 4 Sep 2009, Konstantin Belousov wrote:
>>
>>> Author: kib
>>> Date: Fri Sep  4 14:53:12 2009
>>> New Revision: 196829
>>> URL: http://svn.freebsd.org/changeset/base/196829
>>>
>>> Log:
>>>  Add missing ';'.
>>
>> This hadn't been noticed for a year as up to r196810 PCPU_SET was a
>>     {
>>         ..
>>     }
>> block. With r196811 it was changed to
>>     do {
>>         ..
>>     } while (0)
>> and thus the missing ';' immediately became a syntax error.
> 
> so, why does my tree compile?

I don't understand.. I've been running on that kernel for weeks

> 
>>
>>
>>> Modified:
>>>  head/sys/i386/i386/machdep.c
>>>
>>> Modified: head/sys/i386/i386/machdep.c
>>> ============================================================================== 
>>>
>>> --- head/sys/i386/i386/machdep.c    Fri Sep  4 11:32:05 2009    
>>> (r196828)
>>> +++ head/sys/i386/i386/machdep.c    Fri Sep  4 14:53:12 2009    
>>> (r196829)
>>> @@ -2570,7 +2570,7 @@ init386(first)
>>>     default_proc_ldt.ldt_base = (caddr_t)ldt;
>>>     default_proc_ldt.ldt_len = 6;
>>>     _default_ldt = (int)&default_proc_ldt;
>>> -    PCPU_SET(currentldt, _default_ldt)
>>> +    PCPU_SET(currentldt, _default_ldt);
>>>     PT_SET_MA(ldt, *vtopte((unsigned long)ldt) & ~PG_RW);
>>>     xen_set_ldt((unsigned long) ldt, (sizeof ldt_segs / sizeof 
>>> ldt_segs[0]));
>>>
>>>
>>




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AA153B4.4050408>