Date: Tue, 23 Jun 2026 06:46:50 +0000 From: Kristof Provost <kp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: f4e2f07f0cbc - stable/14 - pfsync: remove invalid panic Message-ID: <6a3a2bda.37dd7.7a1859a@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/14 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=f4e2f07f0cbc976e5a894ab4f3dbbccb15e06d46 commit f4e2f07f0cbc976e5a894ab4f3dbbccb15e06d46 Author: Kristof Provost <kp@FreeBSD.org> AuthorDate: 2026-06-06 13:44:17 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2026-06-23 06:37:59 +0000 pfsync: remove invalid panic When we undefer a packet (when the peer acks the state) it's possible that we don't find a corresponding pfsync_deferral. We panic here, but that's actually something that can happen in normal operation: - if we have too many deferred packets already (in pfsync_defer()) - if the deferral timed out (in pfsync_defer_tmo()) Remove this panic and document the scenarios where it might occur. MFC after: 2 weeks Sponsored by: Orange Business Services (cherry picked from commit 035e87247f845500b4672e10efb8f47fd2c0f2a2) --- sys/netpfil/pf/if_pfsync.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 10883e233b03..4d83962abc74 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2147,7 +2147,11 @@ pfsync_undefer_state_locked(struct pf_kstate *st, int drop) } } - panic("%s: unable to find deferred state", __func__); + /* + * If we don't find this state in b_deferrals that might be because we + * overflowed the list (see pfsync_defer()'s >= 128 check') or because + * the deferral timed out already (see pfsync_defer_tomo()). + */ } static voidhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a3a2bda.37dd7.7a1859a>