Date: Wed, 15 Jul 2009 09:35:44 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-current@freebsd.org Cc: Robert Huff <roberthuff@rcn.com> Subject: Re: repeatable panic in ukbd.c Message-ID: <200907150935.45390.hselasky@c2i.net> In-Reply-To: <19037.18987.220923.425353@jerusalem.litteratus.org> References: <19037.18987.220923.425353@jerusalem.litteratus.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 15 July 2009 05:16:59 Robert Huff wrote:
> After updating to:
>
> FreeBSD 8.0-BETA1 #0: Sun Jul 12 18:26:14 EDT 2009 i386
>
> I suddenly have a recurring but irregular panic:
>
> panic: mutex Giant not owned at /usr/src/sys/dev/usb/input/ukbd.c:986
>
> and a complete crash dump.
> This doesn't seem to be a known problem. To whom should I
> address this?
>
Hi,
We need the backtrace. When I redid the ukbd driver I added the asserts to
catch this kind of issues. The solution in many cases is simply to return a
failure when ukbd is not called having Giant locked. Ukbd has to go away from
the Giant lock, but I'm not confident about the locking strategy in the
keyboard system nowadays, so I've deferred the task.
static int
ukbd_enable(keyboard_t *kbd)
{
mtx_assert(&Giant, MA_OWNED);
KBD_ACTIVATE(kbd);
return (0);
}
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907150935.45390.hselasky>