Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Feb 2016 01:24:10 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r295735 - in head/sys/dev: age alc ale jme msk stge vte
Message-ID:  <201602180124.u1I1OAQk046403@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Thu Feb 18 01:24:10 2016
New Revision: 295735
URL: https://svnweb.freebsd.org/changeset/base/295735

Log:
  Fix variable assignment.
  
  Found by:	PVS-Studio

Modified:
  head/sys/dev/age/if_age.c
  head/sys/dev/alc/if_alc.c
  head/sys/dev/ale/if_ale.c
  head/sys/dev/jme/if_jme.c
  head/sys/dev/msk/if_msk.c
  head/sys/dev/stge/if_stge.c
  head/sys/dev/vte/if_vte.c

Modified: head/sys/dev/age/if_age.c
==============================================================================
--- head/sys/dev/age/if_age.c	Thu Feb 18 00:37:58 2016	(r295734)
+++ head/sys/dev/age/if_age.c	Thu Feb 18 01:24:10 2016	(r295735)
@@ -588,7 +588,7 @@ age_attach(device_t dev)
 	/* Create device sysctl node. */
 	age_sysctl_node(sc);
 
-	if ((error = age_dma_alloc(sc) != 0))
+	if ((error = age_dma_alloc(sc)) != 0)
 		goto fail;
 
 	/* Load station address. */

Modified: head/sys/dev/alc/if_alc.c
==============================================================================
--- head/sys/dev/alc/if_alc.c	Thu Feb 18 00:37:58 2016	(r295734)
+++ head/sys/dev/alc/if_alc.c	Thu Feb 18 01:24:10 2016	(r295735)
@@ -1532,7 +1532,7 @@ alc_attach(device_t dev)
 	/* Create device sysctl node. */
 	alc_sysctl_node(sc);
 
-	if ((error = alc_dma_alloc(sc) != 0))
+	if ((error = alc_dma_alloc(sc)) != 0)
 		goto fail;
 
 	/* Load station address. */

Modified: head/sys/dev/ale/if_ale.c
==============================================================================
--- head/sys/dev/ale/if_ale.c	Thu Feb 18 00:37:58 2016	(r295734)
+++ head/sys/dev/ale/if_ale.c	Thu Feb 18 01:24:10 2016	(r295735)
@@ -603,7 +603,7 @@ ale_attach(device_t dev)
 	/* Create device sysctl node. */
 	ale_sysctl_node(sc);
 
-	if ((error = ale_dma_alloc(sc) != 0))
+	if ((error = ale_dma_alloc(sc)) != 0)
 		goto fail;
 
 	/* Load station address. */

Modified: head/sys/dev/jme/if_jme.c
==============================================================================
--- head/sys/dev/jme/if_jme.c	Thu Feb 18 00:37:58 2016	(r295734)
+++ head/sys/dev/jme/if_jme.c	Thu Feb 18 01:24:10 2016	(r295735)
@@ -804,7 +804,7 @@ jme_attach(device_t dev)
 	}
 	/* Create coalescing sysctl node. */
 	jme_sysctl_node(sc);
-	if ((error = jme_dma_alloc(sc) != 0))
+	if ((error = jme_dma_alloc(sc)) != 0)
 		goto fail;
 
 	ifp = sc->jme_ifp = if_alloc(IFT_ETHER);

Modified: head/sys/dev/msk/if_msk.c
==============================================================================
--- head/sys/dev/msk/if_msk.c	Thu Feb 18 00:37:58 2016	(r295734)
+++ head/sys/dev/msk/if_msk.c	Thu Feb 18 01:24:10 2016	(r295735)
@@ -1623,7 +1623,7 @@ msk_attach(device_t dev)
 	callout_init_mtx(&sc_if->msk_tick_ch, &sc_if->msk_softc->msk_mtx, 0);
 	msk_sysctl_node(sc_if);
 
-	if ((error = msk_txrx_dma_alloc(sc_if) != 0))
+	if ((error = msk_txrx_dma_alloc(sc_if)) != 0)
 		goto fail;
 	msk_rx_dma_jalloc(sc_if);
 

Modified: head/sys/dev/stge/if_stge.c
==============================================================================
--- head/sys/dev/stge/if_stge.c	Thu Feb 18 00:37:58 2016	(r295734)
+++ head/sys/dev/stge/if_stge.c	Thu Feb 18 01:24:10 2016	(r295735)
@@ -508,7 +508,7 @@ stge_attach(device_t dev)
 		}
 	}
 
-	if ((error = stge_dma_alloc(sc) != 0))
+	if ((error = stge_dma_alloc(sc)) != 0)
 		goto fail;
 
 	/*

Modified: head/sys/dev/vte/if_vte.c
==============================================================================
--- head/sys/dev/vte/if_vte.c	Thu Feb 18 00:37:58 2016	(r295734)
+++ head/sys/dev/vte/if_vte.c	Thu Feb 18 01:24:10 2016	(r295735)
@@ -428,7 +428,7 @@ vte_attach(device_t dev)
 	/* Reset the ethernet controller. */
 	vte_reset(sc);
 
-	if ((error = vte_dma_alloc(sc) != 0))
+	if ((error = vte_dma_alloc(sc)) != 0)
 		goto fail;
 
 	/* Create device sysctl node. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602180124.u1I1OAQk046403>