Date: Tue, 23 Mar 2021 19:31:31 +0100 From: tuexen@freebsd.org To: Alan Somers <asomers@freebsd.org> Cc: Kevin Bowling <kevin.bowling@kev009.com>, FreeBSD Net <freebsd-net@freebsd.org>, rscheff@freebsd.org Subject: Re: tcp-testsuite into src? Message-ID: <47E051ED-62D6-4032-8F33-A322F45D93ED@freebsd.org> In-Reply-To: <CAOtMX2ikMjarK0x-wF1RNQvJYQtrrCvLeQAisvES43K6S=zV-A@mail.gmail.com> References: <CAK7dMtB%2B=Ydo4ziznKxj7qV6TsDUH7EzXbeyj0ZT1=zuJDhD=A@mail.gmail.com> <CAOtMX2ikMjarK0x-wF1RNQvJYQtrrCvLeQAisvES43K6S=zV-A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 23. Mar 2021, at 03:45, Alan Somers <asomers@freebsd.org> wrote: > > On Mon, Mar 22, 2021 at 7:31 PM Kevin Bowling <kevin.bowling@kev009.com> wrote: > Hi, > > I was talking with gnn and kevans on IRC about the tcp testsuite > (https://github.com/freebsd-net/tcp-testsuite). > > Currently we maintain this in ports, although the way the port is set > up doesn't make a lot of sense because the tests are stack specific > and we don't account for different FreeBSD versions let alone vendor > trees. It seems reasonable to me to pull the tests themselves (i.e. > https://github.com/freebsd-net/tcp-testsuite) into src where they can > follow along with the tree they are running on, and provide vendors a > natural point of extension. > > /usr/tests has some existing examples of relying on out of tree > binaries to run so I am not convinced we need to import packetdrill > itself but I don't have a strong preference. tuexen, do you have any > preference? > > Regards, > Kevin > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > > Yeah, it's not a problem to use binaries from ports in /usr/tests. As long as the tests can > compile they can live in the base system. Is there a strong incentive to import them? Do The tests are just scripts, which can be executed by packetdrill, which is available in the ports tree. > they need to be adjusted for each release? It depends. If things like default timeouts or so change, then the tests need to be adapted. If we would have (and I guess we will) tests for loss recovery, then improvements to the code might also require changes to the tests. Best regards Michael
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47E051ED-62D6-4032-8F33-A322F45D93ED>