Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 07 Nov 2025 22:41:41 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 46441] sh(1): Does not support PS1, PS2, PS4 parameter expansion
Message-ID:  <bug-46441-227-VXH3k9U8lC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-46441-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=46441

--- Comment #24 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=f9e79facf874567f25147b24863e5198164e8d04

commit f9e79facf874567f25147b24863e5198164e8d04
Author:     Matthew Phillips <matthew@matthewphillips.info>
AuthorDate: 2025-10-12 19:27:34 +0000
Commit:     Jilles Tjoelker <jilles@FreeBSD.org>
CommitDate: 2025-11-07 22:35:18 +0000

    sh: Implement simple parameter expansion in PS1 and PS2

    This change follows a localized approach within getprompt() and avoids
    full parser reentry. While this means we don't support advanced
    expansions like ${parameter#pattern}, it provides POSIX-compliant basic
    parameter expansion without the complexity of making the parser
    reentrant. This is sufficient for the vast majority of use cases.

    PR:             46441

 bin/sh/parser.c                         | 126 +++++++++++++++++++++++++++++++-
 bin/sh/tests/parser/Makefile            |   6 ++
 bin/sh/tests/parser/ps1-expand1.0 (new) |   7 ++
 bin/sh/tests/parser/ps1-expand2.0 (new) |   7 ++
 bin/sh/tests/parser/ps1-expand3.0 (new) |   8 ++
 bin/sh/tests/parser/ps1-expand4.0 (new) |   8 ++
 bin/sh/tests/parser/ps1-expand5.0 (new) |   8 ++
 bin/sh/tests/parser/ps2-expand1.0 (new) |  12 +++
 8 files changed, 181 insertions(+), 1 deletion(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-46441-227-VXH3k9U8lC>